dubbo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [dubbo-go] zouyx commented on a change in pull request #584: Feat: add comment for cluster
Date Wed, 03 Jun 2020 05:54:22 GMT

zouyx commented on a change in pull request #584:
URL: https://github.com/apache/dubbo-go/pull/584#discussion_r434323352



##########
File path: cluster/loadbalance/least_active.go
##########
@@ -28,7 +28,6 @@ import (
 )
 
 const (
-	// LeastActive ...
 	LeastActive = "leastactive"

Review comment:
       I think should add comment for this public var

##########
File path: cluster/cluster.go
##########
@@ -21,7 +21,8 @@ import (
 	"github.com/apache/dubbo-go/protocol"
 )
 
-// Cluster ...
+// Cluster
+//Extension - Cluster

Review comment:
       ```suggestion
   // Extension - Cluster
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Mime
View raw message