falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Srikanth Sundarrajan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-102) Add integration tests for feed entity parser with table defined
Date Fri, 06 Sep 2013 15:03:51 GMT

    [ https://issues.apache.org/jira/browse/FALCON-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13760249#comment-13760249

Srikanth Sundarrajan commented on FALCON-102:

Hi [~s_venkatesh], 
Didn't understand the significance of these string replacements. Can you clarify
+        final String processed = uriTemplate.replaceAll("\\?\\{", "_Q__START_").replaceAll("}",
+        final String processed = catalogTableUri.replaceAll("\\$\\{", "_D__START_").replaceAll("}",

Following is a good candidate for a regex based validation enforced in xsd.
+    private void parseUriTemplate(URI uriTemplate) throws URISyntaxException {

Does it make sense to assume a convention to set different location types as properties within
catalog ? For LocationType.DATA, it can continue to do what it is doing ? In future we can
store stats information from hadoop counters into these through falcon directly and this could
then be leveraged for auto validations and for pure stats based analysis. Thoughts ?
+    /**
+     * LocationType does NOT matter here.
+     */
     public String getUriTemplate(LocationType locationType) {

You probably meant pathType.
+    private LocationType getLocationType(String path) {

FileSystemStorage::getUriTemplate seems to be creating a composite string of all the paths.
Seems like the composite string is build with no further information about the path itself,
and it also skips adding a type if the type is not specified, meaning, given a "#" separated
string, we can't tell one path type from another. The user of this function, may find it challenge
to decompose this.
> Add integration tests for feed entity parser with table defined
> ---------------------------------------------------------------
>                 Key: FALCON-102
>                 URL: https://issues.apache.org/jira/browse/FALCON-102
>             Project: Falcon
>          Issue Type: Sub-task
>    Affects Versions: 0.3
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>         Attachments: FALCON-102.patch
> Having issues to get webhcat up and running. 

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message