falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shwetha G S (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-280) Validate the ACL in entity with the user submitting the entity
Date Wed, 21 May 2014 07:30:38 GMT

    [ https://issues.apache.org/jira/browse/FALCON-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14004443#comment-14004443
] 

Shwetha G S commented on FALCON-280:
------------------------------------

{code}
     @Override
+    public void validateACL(String owner, String group, String permissions) throws FalconException
{
+        // validate that the table exists
+        AbstractCatalogService catalogService = CatalogServiceFactory.getCatalogService();
+        if (!catalogService.tableExists(catalogUrl, database, table, null)) {
+            LOG.error("Table " + table + " doesn't exist");
+            throw new FalconException("Table " + table + " doesn't exist");
+        }
+    }
{code}
table exists check is already done in FeedEntityParser.validateStorageExists()

{code}
+    @Test
+    public void testValidateACL() throws Exception {
+        final Location location = new Location();
+        location.setPath("/foo/bar");
+        location.setType(LocationType.DATA);
+        List<Location> locations = new ArrayList<Location>();
+        locations.add(location);
{code}
Can you add a test where the path(with timed partitions) exists with correct and different
permissions

> Validate the ACL in entity with the user submitting the entity
> --------------------------------------------------------------
>
>                 Key: FALCON-280
>                 URL: https://issues.apache.org/jira/browse/FALCON-280
>             Project: Falcon
>          Issue Type: Bug
>          Components: feed
>    Affects Versions: 0.5
>            Reporter: Venkatesh Seetharam
>            Assignee: Jean-Baptiste Onofré
>             Fix For: 0.6
>
>         Attachments: FALCON-280.patch
>
>
> Also, validate if the user has permissions for storage specified.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message