falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shwetha...@inmobi.com
Subject Re: Review Request 24311: Base line the code and https://issues.apache.org/jira/browse/FALCON-553
Date Thu, 07 Aug 2014 06:37:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24311/#review49872
-----------------------------------------------------------



addons/designer/actions/src/main/java/org/apache/falcon/designer/action/serde/impl/EmailActionSerde.java
<https://reviews.apache.org/r/24311/#comment87273>

    Why don't you use https://sites.google.com/site/gson/gson-user-guide?
    
    All these exceptions should be thrown back instead of returning null and handling null
later.
    
    Isn't serde() common that they can be moved to base class, say configuration



addons/designer/core/src/test/java/org/apache/falcon/designer/storage/impl/HDFSStorageTest.java
<https://reviews.apache.org/r/24311/#comment87275>

    Lets just use local file system with hdfs interface. This adds delay in tests



addons/designer/core/src/test/java/org/apache/falcon/designer/storage/impl/HDFSStorageTest.java
<https://reviews.apache.org/r/24311/#comment87274>

    Shouldn't there be assertFail after this if exception is now thrown


- shwethags


On Aug. 6, 2014, 9:26 a.m., samar kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24311/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2014, 9:26 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-553
>     https://issues.apache.org/jira/browse/FALCON-553
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Base line the code and https://issues.apache.org/jira/browse/FALCON-553 in progress
> 
> 
> Diffs
> -----
> 
>   addons/designer/actions/pom.xml 7d5afbb 
>   addons/designer/actions/src/main/java/org/apache/falcon/designer/action/configuration/EmailActionConfiguration.java
PRE-CREATION 
>   addons/designer/actions/src/main/java/org/apache/falcon/designer/action/serde/ActionSerDe.java
PRE-CREATION 
>   addons/designer/actions/src/main/java/org/apache/falcon/designer/action/serde/impl/EmailActionSerde.java
PRE-CREATION 
>   addons/designer/actions/src/main/java/org/apache/falcon/designer/primitive/action/EmailAction.java
PRE-CREATION 
>   addons/designer/core/pom.xml ddd8814 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/action/serde/PrimitiveSerDe.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/configuration/ActionConfiguration.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/configuration/Configuration.java
dba908a 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/configuration/FlowConfig.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/configuration/TransformConfiguration.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/primitive/Action.java
c40e462 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/primitive/Primitive.java
aa2b988 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/primitive/Transform.java
72cf988 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/storage/impl/HDFSStorage.java
PRE-CREATION 
>   addons/designer/core/src/test/java/org/apache/falcon/designer/storage/impl/HDFSStorageTest.java
PRE-CREATION 
>   addons/designer/flows/pom.xml ce706a3 
>   addons/designer/flows/src/main/java/org/apache/falcon/designer/flow/serde/FlowSerde.java
PRE-CREATION 
>   addons/designer/flows/src/main/java/org/apache/falcon/designer/primitive/Flow.java
PRE-CREATION 
>   addons/designer/pom.xml 3e1a98a 
> 
> Diff: https://reviews.apache.org/r/24311/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> samar kumar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message