falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "samar kumar" <samar.opensou...@gmail.com>
Subject Re: Review Request 24311: Base line the code and https://issues.apache.org/jira/browse/FALCON-553
Date Thu, 07 Aug 2014 08:30:17 GMT


> On Aug. 6, 2014, 8:35 a.m., shwethags wrote:
> > addons/designer/core/src/main/java/org/apache/falcon/designer/action/serde/PrimitiveSerDe.java,
line 34
> > <https://reviews.apache.org/r/24311/diff/3/?file=652010#file652010line34>
> >
> >     shouldn't the serde methods go to configuration?

Wanted to separate the serialization/deserialization functionality and dint want it to get
tied to the value object. Would be easy incase we want to different serialization/deserialization
implementation. Thoughts?


> On Aug. 6, 2014, 8:35 a.m., shwethags wrote:
> > addons/designer/core/src/main/java/org/apache/falcon/designer/primitive/Primitive.java,
line 137
> > <https://reviews.apache.org/r/24311/diff/3/?file=652016#file652016line137>
> >
> >     serde methods should be configuration so this will look like conf.serialise()

Wanted to separate the serialization/deserialization functionality and dint want it to get
tied to the value object. Would be easy incase we want to different serialization/deserialization
implementation. Thoughts?


- samar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24311/#review49717
-----------------------------------------------------------


On Aug. 6, 2014, 9:26 a.m., samar kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24311/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2014, 9:26 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-553
>     https://issues.apache.org/jira/browse/FALCON-553
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Base line the code and https://issues.apache.org/jira/browse/FALCON-553 in progress
> 
> 
> Diffs
> -----
> 
>   addons/designer/actions/pom.xml 7d5afbb 
>   addons/designer/actions/src/main/java/org/apache/falcon/designer/action/configuration/EmailActionConfiguration.java
PRE-CREATION 
>   addons/designer/actions/src/main/java/org/apache/falcon/designer/action/serde/ActionSerDe.java
PRE-CREATION 
>   addons/designer/actions/src/main/java/org/apache/falcon/designer/action/serde/impl/EmailActionSerde.java
PRE-CREATION 
>   addons/designer/actions/src/main/java/org/apache/falcon/designer/primitive/action/EmailAction.java
PRE-CREATION 
>   addons/designer/core/pom.xml ddd8814 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/action/serde/PrimitiveSerDe.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/configuration/ActionConfiguration.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/configuration/Configuration.java
dba908a 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/configuration/FlowConfig.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/configuration/TransformConfiguration.java
PRE-CREATION 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/primitive/Action.java
c40e462 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/primitive/Primitive.java
aa2b988 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/primitive/Transform.java
72cf988 
>   addons/designer/core/src/main/java/org/apache/falcon/designer/storage/impl/HDFSStorage.java
PRE-CREATION 
>   addons/designer/core/src/test/java/org/apache/falcon/designer/storage/impl/HDFSStorageTest.java
PRE-CREATION 
>   addons/designer/flows/pom.xml ce706a3 
>   addons/designer/flows/src/main/java/org/apache/falcon/designer/flow/serde/FlowSerde.java
PRE-CREATION 
>   addons/designer/flows/src/main/java/org/apache/falcon/designer/primitive/Flow.java
PRE-CREATION 
>   addons/designer/pom.xml 3e1a98a 
> 
> Diff: https://reviews.apache.org/r/24311/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> samar kumar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message