falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Gupta" <ar...@hortonworks.com>
Subject Re: Review Request 24717: hcat tests should stop using root dir
Date Thu, 21 Aug 2014 03:34:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24717/#review51156
-----------------------------------------------------------



falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java
<https://reviews.apache.org/r/24717/#comment89195>

    Missing javadoc for this?
    
    Also do you think it would be better to add hdfs to method name for bot these methods?



falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java
<https://reviews.apache.org/r/24717/#comment89196>

    Can we still leave the current base dir as default? Cos it might break existing run configurations.
    
    Also can we come up with a similar default for the app dir? May be /tmp/falcon-regression-app


- Arpit Gupta


On Aug. 19, 2014, 5:22 p.m., Raghav Gautam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24717/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2014, 5:22 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: falcon-606
>     https://issues.apache.org/jira/browse/falcon-606
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> This patch attempts to remove requirement of 777 access to / for hcat tests.
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java
57c7292 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java
1f73523 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java
c33700c 
>   falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java
c64ddad 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatProcessTest.java
32062ba 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatReplicationTest.java
860e680 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatRetentionTest.java
cce2860 
>   falcon-regression/merlin/src/test/resources/hcat/data/_SUCCESS 004c62e 
> 
> Diff: https://reviews.apache.org/r/24717/diff/
> 
> 
> Testing
> -------
> 
> HCatProcessTest, HCatRetention, HCatReplicationTest
> 
> 
> Thanks,
> 
> Raghav Gautam
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message