falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venkatesh Seetharam (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-594) Process lineage information for Retention policies
Date Fri, 22 Aug 2014 19:28:11 GMT

    [ https://issues.apache.org/jira/browse/FALCON-594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107341#comment-14107341

Venkatesh Seetharam commented on FALCON-594:

Few issues with the patch:

* InstanceRelationshipGraphBuilder - why do you need this? this is quite leaky, no?
It should be hidden in the context object or may be FeedEvictor? FeedEvictor can use a helper
which could be used to ser/deser?
We should avoid doing this in multiple places
    private static final String INSTANCEPATH_FORMAT = "instancePaths=";
    private static final String INSTANCEPATH_SEPARATOR = ",";

* Can we add a status as Evicted instead of a property? So we can add Archived in future,
Update the timestamp as well.
feedInstanceVertex.setProperty(RelationshipProperty.EVICTED.getName(), context.getTimeStampAsISO8601());

* rename method from instanceGraphBuilder.updateGraphWithRetentionInfo to addEvictedInstance

* Why do you need changes to EmbeddedCluster - why cant you use EntityBuilderTestUtil?

> Process lineage information for Retention policies
> --------------------------------------------------
>                 Key: FALCON-594
>                 URL: https://issues.apache.org/jira/browse/FALCON-594
>             Project: Falcon
>          Issue Type: Sub-task
>            Reporter: Sowmya Ramesh
>            Assignee: Sowmya Ramesh
>         Attachments: FALCON-594.patch
> Falcon currently addresses process executions and not data lifecycle policies. This task
should address adding this information.

This message was sent by Atlassian JIRA

View raw message