falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 25211: Delegated feed eviction to the appropriate Storage implementation
Date Mon, 01 Sep 2014 13:31:10 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 1, 2014, 1:31 p.m.)

Review request for Falcon and shwethags.


Implemented code review comments

Repository: falcon-git


Earlier FeedEviction class contained logic for both FileSystemStorage and TableStorage. Corresponding
code was being called using an if else. To make the code cleaner and more manageable I moved
the code to the appropriate storage class and delegated feed eviction to the appropriate Storage
implementation. Needed to add evict method to Storage Interface and make some minor changes
here and there.

Diffs (updated)

  common/src/main/java/org/apache/falcon/entity/CatalogStorage.java 7ad0716 
  common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java 4eb3d60 
  common/src/main/java/org/apache/falcon/entity/Storage.java f88e139 
  retention/src/main/java/org/apache/falcon/retention/FeedEvictor.java 4de7938 
  retention/src/test/java/org/apache/falcon/retention/FeedEvictorFileSystemTest.java PRE-CREATION

  retention/src/test/java/org/apache/falcon/retention/FeedEvictorTest.java eb4173e 

Diff: https://reviews.apache.org/r/25211/diff/


All FeedEvictor tests passed.


Ajay Yadava

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message