falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raghav Gautam" <rag...@apache.org>
Subject Re: Review Request 31131: Add test for FALCON-677 - wherein feed data and stats paths no longer default to /tmp/
Date Tue, 17 Feb 2015 22:36:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31131/#review72807
-----------------------------------------------------------



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSubmitTest.java
<https://reviews.apache.org/r/31131/#comment118887>

    We are assuming that 2nd location is for stat. Can we do something on the line:
    feedObj.setLocation(LocationType.STAT, null)
    
    You have done this in submitFeedWithEmptyDataPath().



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSubmitTest.java
<https://reviews.apache.org/r/31131/#comment118888>

    same as above.


I noticed some issues - plase address them and ignore my previous +1.

- Raghav Gautam


On Feb. 17, 2015, 12:26 p.m., Karishma Gulati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31131/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2015, 12:26 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Earlier if in a feed, the data and stats paths weren't mentioned, they'd default to /tmp/.
Now, feed submission should fail if data path is not mentioned. More details at https://issues.apache.org/jira/browse/FALCON-677
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSubmitTest.java
374c442 
> 
> Diff: https://reviews.apache.org/r/31131/diff/
> 
> 
> Testing
> -------
> 
> Added changes to FeedSubmitTest
> 
> 
> Thanks,
> 
> Karishma Gulati
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message