falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karishma Gulati" <gulati.karis...@yahoo.com>
Subject Re: Review Request 31131: Add test for FALCON-677 - wherein feed data and stats paths no longer default to /tmp/
Date Thu, 19 Feb 2015 07:46:01 GMT


> On Feb. 17, 2015, 10:36 p.m., Raghav Gautam wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSubmitTest.java,
line 145
> > <https://reviews.apache.org/r/31131/diff/1/?file=866512#file866512line145>
> >
> >     We are assuming that 2nd location is for stat. Can we do something on the line:
> >     feedObj.setLocation(LocationType.STAT, null)
> >     
> >     You have done this in submitFeedWithEmptyDataPath().

If you do feedObj.setLocation(LocationType.STAT, null), then it'll give you the location tag
as <location type="stats" path/>. However what is required is for the entire <location
type="stats"/> to not be there in the feed. However, you are right as to how we should
assume the positions of the location types. Added a new function in FeedMerlin for it. Lemme
know if it makes sense now!


- Karishma


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31131/#review72807
-----------------------------------------------------------


On Feb. 17, 2015, 8:26 p.m., Karishma Gulati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31131/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2015, 8:26 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Earlier if in a feed, the data and stats paths weren't mentioned, they'd default to /tmp/.
Now, feed submission should fail if data path is not mentioned. More details at https://issues.apache.org/jira/browse/FALCON-677
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSubmitTest.java
374c442 
> 
> Diff: https://reviews.apache.org/r/31131/diff/
> 
> 
> Testing
> -------
> 
> Added changes to FeedSubmitTest
> 
> 
> Thanks,
> 
> Karishma Gulati
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message