falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karishma Gulati" <gulati.karis...@yahoo.com>
Subject Re: Review Request 31353: [Falcon-1046] Add test for process update with user feature
Date Fri, 27 Feb 2015 09:07:32 GMT


> On Feb. 26, 2015, 5:04 a.m., samarth gupta wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/AuthorizationTest.java,
line 648
> > <https://reviews.apache.org/r/31353/diff/1/?file=873928#file873928line648>
> >
> >     how was the validity set till now ? why do we need to set it explicitly now
?

The validity of the process-template in ELBundle ends in 2011. So update doesn't work for
that process. Hence you'll see that all tests that update the process are explicitly setting
the validity of the process as well.


- Karishma


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31353/#review74211
-----------------------------------------------------------


On Feb. 24, 2015, 1:12 p.m., Karishma Gulati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31353/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2015, 1:12 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> More details can be found at : https://issues.apache.org/jira/browse/FALCON-430.
> Example Test Case:
> FeedA Scheduled by U1, Dependent Process by U2, FeedA Updated by U1 -> New Bundle
for FeedA with U1, New Bundle for Process with U2 (and not U1) created.
> 
> Similarly, have identified a couple of other test cases.
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/AuthorizationTest.java
4787ef1 
> 
> Diff: https://reviews.apache.org/r/31353/diff/
> 
> 
> Testing
> -------
> 
> Added Tests to Authorization Test.
> 
> 
> Thanks,
> 
> Karishma Gulati
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message