falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Balu Vellanki" <bvella...@hortonworks.com>
Subject Re: Review Request 33867: Falcon-1195 - ClusterEntityParserTest fails intermittently
Date Wed, 06 May 2015 22:30:55 GMT


> On May 6, 2015, 5:47 p.m., Sowmya Ramesh wrote:
> > common/src/test/java/org/apache/falcon/entity/parser/ClusterEntityParserTest.java,
line 366
> > <https://reviews.apache.org/r/33867/diff/1/?file=950616#file950616line366>
> >
> >     Can this method be modified to return unique locations instead of caller passing
it? This would avoid conflict when new tests are written and the same locations are reused.
Also please add the cleanup method which cleans up all the locations created.

@sowmya - The caller needs to know the exact working and staging locations for some test cases.
Hence caller should pass them to the method. I added a cleanup method and improved the ValidationException
verification. Please review.


- Balu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33867/#review82698
-----------------------------------------------------------


On May 5, 2015, 10:37 p.m., Balu Vellanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33867/
> -----------------------------------------------------------
> 
> (Updated May 5, 2015, 10:37 p.m.)
> 
> 
> Review request for Falcon, Sowmya Ramesh and Venkat Ranganathan.
> 
> 
> Bugs: Falcon-1195
>     https://issues.apache.org/jira/browse/Falcon-1195
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> testClusterWithOnlyStaging fails intermittently due to race condition in creating working
dir for cluster. This can be fixed by creating a different working/staging dir for each test
case.
> 
> 
> Diffs
> -----
> 
>   common/src/test/java/org/apache/falcon/entity/parser/ClusterEntityParserTest.java 4920d03

> 
> Diff: https://reviews.apache.org/r/33867/diff/
> 
> 
> Testing
> -------
> 
> Ran unit tests multiple times to verify the changes.
> 
> 
> Thanks,
> 
> Balu Vellanki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message