falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 33892: FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable
Date Thu, 07 May 2015 10:51:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33892/#review82815
-----------------------------------------------------------



oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java
<https://reviews.apache.org/r/33892/#comment133645>

    We also need to log (warning) here that no new libraries were copied. If any new libraries
were added then they will have to be copied manually.



oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java
<https://reviews.apache.org/r/33892/#comment133644>

    How about just catching the exception here and remove all other changes? This way during
reload we can silence the error in copying libs to HDFS without changing the code anywhere
else.


- Ajay Yadava


On May 6, 2015, 12:47 p.m., Peeyush Bishnoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33892/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 12:47 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1165
>     https://issues.apache.org/jira/browse/FALCON-1165
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable
> 
> 
> Diffs
> -----
> 
>   oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java b3b7bf3

> 
> Diff: https://reviews.apache.org/r/33892/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Peeyush Bishnoi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message