falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 34192: FALCON-1060 Handle transaction failures in Lineage
Date Thu, 28 May 2015 12:10:06 GMT


> On May 27, 2015, 1:49 p.m., Balu Vellanki wrote:
> > common/src/main/java/org/apache/falcon/metadata/MetadataMappingService.java, line
78
> > <https://reviews.apache.org/r/34192/diff/2/?file=972528#file972528line78>
> >
> >     Minor nit - Please use "private final int" and change the name to match checkstyle
rules.

It's being populated in init() instead of the constructor so final won't work.


- Ajay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34192/#review85359
-----------------------------------------------------------


On May 27, 2015, 9:11 a.m., pavan kumar kolamuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34192/
> -----------------------------------------------------------
> 
> (Updated May 27, 2015, 9:11 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Handle transaction failures in Lineage , Rolling back transactions if they are partial.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/metadata/EntityRelationshipGraphBuilder.java
d90f7ec 
>   common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java
2288443 
>   common/src/main/java/org/apache/falcon/metadata/MetadataMappingService.java 9137fe0

>   common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java 11d27fe

>   pom.xml 47718ba 
> 
> Diff: https://reviews.apache.org/r/34192/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message