falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raghav Gautam" <rag...@apache.org>
Subject Re: Review Request 34931: [FALCON-1246] Remove wrong parameter from update signature, disable related tests UpdateAtSpecificTimeTest#invalidCharFeed(), invalidCharProcess()
Date Tue, 02 Jun 2015 21:26:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34931/#review86286
-----------------------------------------------------------



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceListingTest.java
<https://reviews.apache.org/r/34931/#comment138264>

    Consider using update(oldEntity, newEntity) method instead.
    
    this would call update(oldEntity, newEntity, null)
    
    This is applicable at multiple places.



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/UpdateAtSpecificTimeTest.java
<https://reviews.apache.org/r/34931/#comment138266>

    Now that these tests just don't make sense, shouldn't we just delete them. Any reason
to keep them around.



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/UpdateAtSpecificTimeTest.java
<https://reviews.apache.org/r/34931/#comment138267>

    same here


- Raghav Gautam


On June 2, 2015, 4:22 a.m., Paul Isaychuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34931/
> -----------------------------------------------------------
> 
> (Updated June 2, 2015, 4:22 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1246
>     https://issues.apache.org/jira/browse/FALCON-1246
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Effective time is wrong parameter which is not being taken into account by API. Removed
it from update signature and related tests.
> UpdateAtSpecificTimeTest#invalidCharFeed(),invalidCharProcess() were based on enteting
invalid effective time, disabling them.
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java
4dce3f3 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/ClusterEntityHelper.java
4ea6728 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/AuthorizationTest.java
24af21f 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceListingTest.java
813300d 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/EntityDryRunTest.java
32d5e24 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/UpdateAtSpecificTimeTest.java
9ff8016 
> 
> Diff: https://reviews.apache.org/r/34931/diff/
> 
> 
> Testing
> -------
> 
> FeedInstanceListingTest
> 
> 
> Thanks,
> 
> Paul Isaychuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message