falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venkat Ranganathan" <n....@live.com>
Subject Review Request 38041: FALCON-1429: Fix Falcon monitoring, alert, audit and monitoring plugins by fixing aspectj handling
Date Wed, 02 Sep 2015 05:35:36 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for Falcon.

Bugs: FALCON-1429

Repository: falcon-git


Updated Aspectj version to 1.8.6,
Fixed weaver dependency to also include the metrics project with GenericAlert handling. 
Fixed null pointer handling in around advice for audits


  metrics/src/main/java/org/apache/falcon/aspect/AbstractFalconAspect.java b358011 
  metrics/src/main/java/org/apache/falcon/aspect/GenericAlert.java 321c769 
  pom.xml 583d095 
  prism/pom.xml 1e68e82 

Diff: https://reviews.apache.org/r/38041/diff/


Ran mvn clean install -Phadoop-2,test-patch
All Tests passed

You may see the following warning (I changed the ajc lint level to warning so that we can
see issues if any) 

WARNING] can not implement lazyTjp on this joinpoint method-execution(java.lang.String org.apache.falcon.aspect.GenericAlert.audit(java.lang.String,
java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String))
because around advice is used [Xlint:canNotImplementLazyTjp]

That is because the aspects are broadly applicable.   May be we can fix the Pointcuts later


Venkat Ranganathan

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message