----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38041/ ----------------------------------------------------------- (Updated Sept. 2, 2015, 9:57 a.m.) Review request for Falcon. Changes ------- Thanks for the quick review Ajay. Fixed the comments Bugs: FALCON-1429 https://issues.apache.org/jira/browse/FALCON-1429 Repository: falcon-git Description ------- Updated Aspectj version to 1.8.6, Fixed weaver dependency to also include the metrics project with GenericAlert handling. Fixed null pointer handling in around advice for audits Diffs (updated) ----- metrics/src/main/java/org/apache/falcon/aspect/AbstractFalconAspect.java b358011 metrics/src/main/java/org/apache/falcon/aspect/GenericAlert.java 321c769 pom.xml 583d095 prism/pom.xml 1e68e82 prism/src/test/java/org/apache/falcon/aspect/GenericAlertTest.java 919f821 Diff: https://reviews.apache.org/r/38041/diff/ Testing ------- Ran mvn clean install -Phadoop-2,test-patch All Tests passed You may see the following warning (I changed the ajc lint level to warning so that we can see issues if any) WARNING] can not implement lazyTjp on this joinpoint method-execution(java.lang.String org.apache.falcon.aspect.GenericAlert.audit(java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String)) because around advice is used [Xlint:canNotImplementLazyTjp] That is because the aspects are broadly applicable. May be we can fix the Pointcuts later Thanks, Venkat Ranganathan