From dev-return-15172-apmail-falcon-dev-archive=falcon.apache.org@falcon.apache.org Tue Sep 22 17:14:55 2015 Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5BDC61763E for ; Tue, 22 Sep 2015 17:14:55 +0000 (UTC) Received: (qmail 18625 invoked by uid 500); 22 Sep 2015 17:14:55 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 18586 invoked by uid 500); 22 Sep 2015 17:14:55 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 18574 invoked by uid 99); 22 Sep 2015 17:14:55 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Sep 2015 17:14:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8B4A7F6273 for ; Tue, 22 Sep 2015 17:14:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 5.169 X-Spam-Level: ***** X-Spam-Status: No, score=5.169 tagged_above=-999 required=6.31 tests=[FORGED_HOTMAIL_RCVD2=1.187, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=0.001] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id pefxHUOJiLrz for ; Tue, 22 Sep 2015 17:14:53 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id 87A1B42BE9 for ; Tue, 22 Sep 2015 17:14:52 +0000 (UTC) Received: (qmail 72364 invoked by uid 99); 22 Sep 2015 15:28:12 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Sep 2015 15:28:12 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C8661285BE9; Tue, 22 Sep 2015 15:28:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2089170333252730724==" MIME-Version: 1.0 Subject: Re: Review Request 38450: FALCON-965 Open up Feed lifecycle for user extension From: "Srikanth Sundarrajan" To: "Ajay Yadava" , "Falcon" , "Srikanth Sundarrajan" Date: Tue, 22 Sep 2015 15:28:09 -0000 Message-ID: <20150922152809.31021.53045@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Srikanth Sundarrajan" X-ReviewGroup: Falcon X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38450/ X-Sender: "Srikanth Sundarrajan" References: <20150920154052.24658.98824@reviews.apache.org> In-Reply-To: <20150920154052.24658.98824@reviews.apache.org> Reply-To: "Srikanth Sundarrajan" X-ReviewRequest-Repository: falcon-git --===============2089170333252730724== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38450/#review99990 ----------------------------------------------------------- common/src/main/java/org/apache/falcon/entity/FeedHelper.java (line 380) Should this be a FeedHelper util function ? common/src/main/java/org/apache/falcon/entity/FeedHelper.java (line 399) How will work when there are multiple stages? Would we have to modify this piece of code for each new stage being added ? common/src/main/java/org/apache/falcon/lifecycle/retention/AgeBasedDelete.java (line 36) Find and replace occurences of nominalTime lifecycle/pom.xml (line 101) Do we need the oozie-schemas to be present again inside the lifecycle module ? lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/OoziePolicyBuilderFactory.java (line 38) If builders are empty ? lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/utils/OozieBuilderUtils.java (line 158) Do we want to hidethis behind private scope ? pom.xml (line 418) Check indentation - Srikanth Sundarrajan On Sept. 20, 2015, 3:40 p.m., Ajay Yadava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38450/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2015, 3:40 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-965 > https://issues.apache.org/jira/browse/FALCON-965 > > > Repository: falcon-git > > > Description > ------- > > For details on feed lifecycle feature and motivation behind it, please refer FALCON-965. This is the base framework for lifecycle with a feature parity of retention stage as a reference implementation. > > > Diffs > ----- > > client/src/main/resources/feed-0.1.xsd 2af28d2 > common/src/main/java/org/apache/falcon/entity/FeedHelper.java 572923b > common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java 992fc51 > common/src/main/java/org/apache/falcon/lifecycle/AbstractPolicyBuilderFactory.java PRE-CREATION > common/src/main/java/org/apache/falcon/lifecycle/FeedLifecycleStage.java PRE-CREATION > common/src/main/java/org/apache/falcon/lifecycle/LifecyclePolicy.java PRE-CREATION > common/src/main/java/org/apache/falcon/lifecycle/PolicyBuilder.java PRE-CREATION > common/src/main/java/org/apache/falcon/lifecycle/retention/AgeBasedDelete.java PRE-CREATION > common/src/main/java/org/apache/falcon/lifecycle/retention/RetentionPolicy.java PRE-CREATION > common/src/main/java/org/apache/falcon/service/LifecyclePolicyMap.java PRE-CREATION > common/src/main/java/org/apache/falcon/workflow/WorkflowEngineFactory.java 756c6b8 > common/src/main/resources/startup.properties 9db460c > common/src/test/java/org/apache/falcon/entity/AbstractTestBase.java 6179855 > common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java c70cfcc > common/src/test/java/org/apache/falcon/entity/parser/FeedEntityParserTest.java 1e9b72f > common/src/test/resources/config/feed/feed-0.3.xml PRE-CREATION > common/src/test/resources/config/feed/feed-0.4.xml PRE-CREATION > lifecycle/pom.xml PRE-CREATION > lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/OoziePolicyBuilderFactory.java PRE-CREATION > lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedCoordinatorBuilder.java PRE-CREATION > lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedDeleteBuilder.java PRE-CREATION > lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedWorkflowBuilder.java PRE-CREATION > lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/utils/OozieBuilderUtils.java PRE-CREATION > lifecycle/src/main/resources/action/feed/eviction-action.xml PRE-CREATION > lifecycle/src/main/resources/binding/jaxb-binding.xjb PRE-CREATION > lifecycle/src/test/java/org/apache/falcon/lifecycle/retention/AgeBasedDeleteTest.java PRE-CREATION > oozie/pom.xml 157edf9 > oozie/src/main/java/org/apache/falcon/oozie/feed/FeedBundleBuilder.java b819dee > oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java 7d0174a > oozie/src/test/resources/feed/fs-retention-feed.xml PRE-CREATION > oozie/src/test/resources/feed/fs-retention-lifecycle-feed.xml PRE-CREATION > pom.xml 646de69 > src/conf/startup.properties 8f3bc35 > > Diff: https://reviews.apache.org/r/38450/diff/ > > > Testing > ------- > > Unit tests have been added for all the methods. > I have compared the new artifacts(workflow, bundle, config-default and coordinator xmls) with the old ones. > > > Thanks, > > Ajay Yadava > > --===============2089170333252730724==--