falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 40357: Falcon should not retry in case of an instance being manual kill from user.
Date Wed, 18 Nov 2015 01:37:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40357/#review106854
-----------------------------------------------------------



common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java (line 139)
<https://reviews.apache.org/r/40357/#comment165664>

    nit: Can you please separate the getValues calls on separate lines for readability?



common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java (line 141)
<https://reviews.apache.org/r/40357/#comment165665>

    Did you mean Exception instead of just FalconException or are you interested in catching
only the error from FalconWorkflowEngine?



oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java (line 1672)
<https://reviews.apache.org/r/40357/#comment165852>

    nit: you can reuse the client from above



scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java (line
368)
<https://reviews.apache.org/r/40357/#comment165667>

    nit: UnsupportedOperationException might be more suitable for this case and it will also
help in distinguishing unimplemented methods from underlying errors as well.


- Ajay Yadava


On Nov. 17, 2015, 6:30 a.m., sandeep samudrala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40357/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2015, 6:30 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1597
>     https://issues.apache.org/jira/browse/FALCON-1597
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> As of now falcon doesn't distinguish between kill(failure in some form) and manual kill.
In case of an instance being a manual kill, falcon should stop retrying on that instance.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java 899165b

>   common/src/main/java/org/apache/falcon/workflow/WorkflowJobEndNotificationService.java
9d96fa3 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java
8b3460a 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7262964

>   rerun/src/main/java/org/apache/falcon/rerun/handler/RetryHandler.java 7aa094a 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java
8dcf3a5 
> 
> Diff: https://reviews.apache.org/r/40357/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing done to check for instances only those failed get retried.
> 
> 
> Thanks,
> 
> sandeep samudrala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message