falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 40481: Need ability to provide the path for recipe files in command line
Date Fri, 20 Nov 2015 02:40:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40481/#review107292
-----------------------------------------------------------



client/src/main/java/org/apache/falcon/cli/FalconRecipeCLI.java (line 43)
<https://reviews.apache.org/r/40481/#comment166323>

    Do you think "file" instead of "properties" will be more intuitive?



client/src/main/java/org/apache/falcon/cli/FalconRecipeCLI.java (line 107)
<https://reviews.apache.org/r/40481/#comment166327>

    I think only having a file exists check should be enough for validation.



client/src/main/java/org/apache/falcon/cli/FalconRecipeCLI.java (line 110)
<https://reviews.apache.org/r/40481/#comment166324>

    It is a mandatory parameter and if it is blank then it's fine?



client/src/main/java/org/apache/falcon/cli/FalconRecipeCLI.java (line 119)
<https://reviews.apache.org/r/40481/#comment166325>

    Any reason for having the restriction that the properties file should match the recipe
name? I am not able to appreciate it's usefulness and it looks restrictive to me.



client/src/main/java/org/apache/falcon/client/FalconClient.java (line 1108)
<https://reviews.apache.org/r/40481/#comment166326>

    Can you please add it in the client.properties so that it's easier for users to figure
out which property value to override?



client/src/main/java/org/apache/falcon/client/FalconClient.java (line 1152)
<https://reviews.apache.org/r/40481/#comment166329>

    Earlier this path was the value of ""falcon.recipe.path" in client.properties and now
it has extra sub path added to it. Was it broken earlier?


- Ajay Yadava


On Nov. 19, 2015, 2:02 p.m., Peeyush Bishnoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40481/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 2:02 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1588
>     https://issues.apache.org/jira/browse/FALCON-1588
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> FALCON-1588 : Need ability to provide the path for recipe files in command line
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconRecipeCLI.java b93fed2 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java c49dd08 
> 
> Diff: https://reviews.apache.org/r/40481/diff/
> 
> 
> Testing
> -------
> 
> yes.
> 
> 
> Thanks,
> 
> Peeyush Bishnoi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message