falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 39844: FALCON-1233 Support co-existence of Oozie scheduler (coord) and Falcon native scheduler.
Date Fri, 20 Nov 2015 05:08:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39844/#review105231
-----------------------------------------------------------



common/src/main/java/org/apache/falcon/workflow/WorkflowEngineFactory.java (line 90)
<https://reviews.apache.org/r/39844/#comment166348>

    nit: can you please log the entity for which it is returned as well?



common/src/main/java/org/apache/falcon/workflow/WorkflowEngineFactory.java (line 100)
<https://reviews.apache.org/r/39844/#comment163720>

    Why is a map required to be sent when we are using only one property?



common/src/main/java/org/apache/falcon/workflow/WorkflowEngineFactory.java (line 140)
<https://reviews.apache.org/r/39844/#comment166344>

    nit: Isn't it already available in WFENGINE.PRIMARY.getEngine()?



docs/src/site/twiki/FalconCLI.twiki (line 57)
<https://reviews.apache.org/r/39844/#comment163719>

    Can you please add a little bit of description on the use case for this command? The name
secondary doesn't convey much.


- Ajay Yadava


On Nov. 3, 2015, 5:50 a.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39844/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 5:50 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1233
>     https://issues.apache.org/jira/browse/FALCON-1233
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> The migration to Falcon native scheduler should be as seamless as possible and the user
should be able to migrate to the native scheduler in a phased manner (entity by entity).
> 
> This patch introduces the notion of primary and secondary workflow engines. It allows
users to schedule an entity on the secondary engine (primary, by default). The idea is that
initially, users will use Falcon native scheduler as the secondary engine to migrate their
entities one by one. When most entities have been migrated, the Oozie scheduler becomes secondary
(and eventually removed).
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/workflow/WorkflowEngineFactory.java 49592ac

>   common/src/main/java/org/apache/falcon/workflow/WorkflowJobEndNotificationService.java
9d96fa3 
>   docs/src/site/twiki/FalconCLI.twiki e001a7f 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 16ef83a 
>   prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java fea2989

>   prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java
d317aa1 
>   scheduler/src/test/java/org/apache/falcon/execution/FalconExecutionServiceTest.java
b2f9e59 
>   scheduler/src/test/java/org/apache/falcon/workflow/engine/WorkflowEngineFactoryTest.java
PRE-CREATION 
>   src/conf/startup.properties ce6e91f 
> 
> Diff: https://reviews.apache.org/r/39844/diff/
> 
> 
> Testing
> -------
> 
> UTs added. Manual testing done.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message