falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "pavan kumar kolamuri" <pavan.kolam...@gmail.com>
Subject Re: Review Request 39588: State Store for instances scheduled by Falcon Native Scheduler
Date Wed, 25 Nov 2015 12:42:55 GMT


> On Oct. 26, 2015, 11:35 a.m., Pallavi Rao wrote:
> > scheduler/src/main/java/org/apache/falcon/state/store/service/FalconJPAService.java,
line 114
> > <https://reviews.apache.org/r/39588/diff/1/?file=1104029#file1104029line114>
> >
> >     May be a concern if you expect admins to specify the DB password in clear text.
May be we can add an option to also get it from the command prompt (admin types it in), if
the password is not specified.
> 
> pavan kumar kolamuri wrote:
>     Currently oozie also does the same. If it is needed further , we will discuss and
raise jira jira to track it

Tracked in https://issues.apache.org/jira/browse/FALCON-1601


- pavan kumar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39588/#review103989
-----------------------------------------------------------


On Nov. 25, 2015, 11:52 a.m., pavan kumar kolamuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39588/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2015, 11:52 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/FALCON-1234
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FALCON-1234
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Persistent State Store for Falcon Native Scheduler
> 
> 
> Diffs
> -----
> 
>   checkstyle/src/main/resources/falcon/checkstyle.xml 2130e73 
>   checkstyle/src/main/resources/falcon/findbugs-exclude.xml 0a7580d 
>   common/src/main/resources/startup.properties cc5212a 
>   pom.xml fad8902 
>   scheduler/pom.xml 20a91d2 
>   scheduler/src/main/java/org/apache/falcon/execution/ExecutionInstance.java 2d6b67d

>   scheduler/src/main/java/org/apache/falcon/execution/FalconExecutionService.java b48a65b

>   scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutionInstance.java 434f168

>   scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java fb4c8c9 
>   scheduler/src/main/java/org/apache/falcon/state/EntityState.java 15aea9a 
>   scheduler/src/main/java/org/apache/falcon/state/InstanceID.java a722be9 
>   scheduler/src/main/java/org/apache/falcon/state/InstanceState.java ada9d2b 
>   scheduler/src/main/java/org/apache/falcon/state/StateService.java c1671ac 
>   scheduler/src/main/java/org/apache/falcon/state/store/AbstractStateStore.java e36f85c

>   scheduler/src/main/java/org/apache/falcon/state/store/EntityStateStore.java 113f4c5

>   scheduler/src/main/java/org/apache/falcon/state/store/InMemoryStateStore.java 52b3bb8

>   scheduler/src/main/java/org/apache/falcon/state/store/InstanceStateStore.java 483d9e6

>   scheduler/src/main/java/org/apache/falcon/state/store/StateStore.java f595c26 
>   scheduler/src/main/java/org/apache/falcon/state/store/jdbc/BeanMapperUtil.java PRE-CREATION

>   scheduler/src/main/java/org/apache/falcon/state/store/jdbc/EntityBean.java PRE-CREATION

>   scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java PRE-CREATION

>   scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java PRE-CREATION

>   scheduler/src/main/java/org/apache/falcon/state/store/service/FalconJPAService.java
PRE-CREATION 
>   scheduler/src/main/java/org/apache/falcon/tools/FalconStateStoreDBCLI.java PRE-CREATION

>   scheduler/src/main/resources/META-INF/persistence.xml PRE-CREATION 
>   scheduler/src/main/resources/falcon-buildinfo.properties PRE-CREATION 
>   scheduler/src/test/java/org/apache/falcon/execution/FalconExecutionServiceTest.java
bff92c9 
>   scheduler/src/test/java/org/apache/falcon/notification/service/SchedulerServiceTest.java
001f466 
>   scheduler/src/test/java/org/apache/falcon/state/AbstractSchedulerTestBase.java PRE-CREATION

>   scheduler/src/test/java/org/apache/falcon/state/EntityStateServiceTest.java 2f32b43

>   scheduler/src/test/java/org/apache/falcon/state/InstanceStateServiceTest.java 43c3c54

>   scheduler/src/test/java/org/apache/falcon/state/service/TestFalconJPAService.java PRE-CREATION

>   scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java
PRE-CREATION 
>   scheduler/src/test/java/org/apache/falcon/tools/TestFalconStateStoreDBCLI.java PRE-CREATION

>   scheduler/src/test/resources/startup.properties PRE-CREATION 
>   src/bin/falcon-db.sh PRE-CREATION 
>   src/conf/startup.properties ce6e91f 
>   src/main/assemblies/distributed-package.xml 794eaef 
>   src/main/assemblies/standalone-package.xml fcff8d7 
>   unit/src/main/resources/startup.properties fe6f430 
> 
> Diff: https://reviews.apache.org/r/39588/diff/
> 
> 
> Testing
> -------
> 
> I have written unit tests. I will also test externally by setting up everything
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message