falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajay Yadava" <ajayn...@gmail.com>
Subject Re: Review Request 42449: Code Refactoring for Falcon Client
Date Mon, 18 Jan 2016 11:47:21 GMT


> On Jan. 18, 2016, 8:40 a.m., Pallavi Rao wrote:
> > client/src/main/java/org/apache/falcon/client/FalconClient.java, line 381
> > <https://reviews.apache.org/r/42449/diff/1/?file=1199867#file1199867line381>
> >
> >     May be we can have a common method to add all common params (doAsUser), so common
changes can be made in single place. 
> >     
> >     Since there is only such param, it might be ok now. But, it sets a good precedence
for further changes.

I thought about that but DO_AS is also not there for all apis.


> On Jan. 18, 2016, 8:40 a.m., Pallavi Rao wrote:
> > client/src/main/java/org/apache/falcon/client/FalconClient.java, line 538
> > <https://reviews.apache.org/r/42449/diff/1/?file=1199867#file1199867line538>
> >
> >     Can't use getResponse() method?

Yes, we should. This is an oversight(it was a tedious JIRA), will fix it.


> On Jan. 18, 2016, 8:40 a.m., Pallavi Rao wrote:
> > client/src/main/java/org/apache/falcon/client/FalconClient.java, line 412
> > <https://reviews.apache.org/r/42449/diff/1/?file=1199867#file1199867line412>
> >
> >     validate does not use sendEntityRequestWithObject method, whereas submit and
submitAndSchedule use it. Why the difference?

Will refactor it and ensure it is consistent.


> On Jan. 18, 2016, 8:40 a.m., Pallavi Rao wrote:
> > client/src/main/java/org/apache/falcon/client/FalconClient.java, line 431
> > <https://reviews.apache.org/r/42449/diff/1/?file=1199867#file1199867line431>
> >
> >     Can't use sendEntityRequestWithObject method?

Will make it consistent everywhere.


> On Jan. 18, 2016, 8:40 a.m., Pallavi Rao wrote:
> > client/src/main/java/org/apache/falcon/client/FalconClient.java, line 770
> > <https://reviews.apache.org/r/42449/diff/1/?file=1199867#file1199867line770>
> >
> >     Can't use getResponse() method?

Yes we can and we should, thanks for catching it.


- Ajay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42449/#review114967
-----------------------------------------------------------


On Jan. 18, 2016, 7:24 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42449/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2016, 7:24 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1707
>     https://issues.apache.org/jira/browse/FALCON-1707
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Code Refactoring for Falcon Client
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 3f3a871 
> 
> Diff: https://reviews.apache.org/r/42449/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message