falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yzheng-hortonworks <...@git.apache.org>
Subject [GitHub] falcon pull request #168: FALCON-1965 Update ActiveMQ version to 5.13.3 to a...
Date Fri, 03 Jun 2016 16:12:11 GMT
GitHub user yzheng-hortonworks opened a pull request:

    https://github.com/apache/falcon/pull/168

    FALCON-1965 Update ActiveMQ version to 5.13.3 to avoid Falcon start error after rolling
upgrade

    Upgraded ActiveMQ version to the latest 5.13.3. Tested Falcon server upgrade with ActiveMQ
history works with 0.6, 0.7 and trunk. Fixed two test failures due to the upgrade:
    
    1. JMSMessageConsumerTest
    After upgrade, some messages are consumed faster and so the initial expectation on no
message being dequeued right after the message sending doesn't hold. Also confirmed with @bvellanki
that this kind of tests are flaky and have caused intermittent test errors before. Therefore,
removed getTotalDequeueCount assertion. In addition, the expected message consumptions are
tested in existing code "Mockito.verify(jobEndService,...".
    
    2. FalconPostProcessingTest
    After upgrade, Falcon will run into an error if it tries to delete messages when ActiveMQ
service is stopped. Therefore, need to call start before deleting the message during teardown.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yzheng-hortonworks/falcon FALCON-1965

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/falcon/pull/168.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #168
    
----
commit 02cadda20e312b17fd8a03bb9cae62b6d85063e4
Author: yzheng-hortonworks <yzheng@hortonworks.com>
Date:   2016-06-01T20:55:11Z

    FALCON-1965 Update ActiveMQ version to 5.13.3 to avoid Falcon start error after rolling
upgrade

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message