falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yzheng-hortonworks <...@git.apache.org>
Subject [GitHub] falcon pull request #169: FALCON-2010 Fix UT errors due to ActiveMQ upgrade
Date Fri, 03 Jun 2016 19:13:06 GMT
GitHub user yzheng-hortonworks opened a pull request:


    FALCON-2010 Fix UT errors due to ActiveMQ upgrade

    Fixed two test failures due to the upgrade:
    1. JMSMessageConsumerTest
    After upgrade, some messages are consumed faster and so the initial expectation on no
message being dequeued right after the message sending doesn't hold. Also confirmed with @bvellanki
that this kind of tests are flaky and have caused intermittent test errors before. Therefore,
removed getTotalDequeueCount assertion. In addition, the expected message consumptions are
tested in existing code "Mockito.verify(jobEndService,...".
    2. FalconPostProcessingTest
    After upgrade, Falcon will run into an error if it tries to delete messages when ActiveMQ
service is stopped. Therefore, need to call start before deleting the message during teardown.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yzheng-hortonworks/falcon FALCON-2010

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #169
commit 950407a7a956d25b07c1fc39ebdd3d0eca86195b
Author: yzheng-hortonworks <yzheng@hortonworks.com>
Date:   2016-06-03T19:12:04Z

    FALCON-2010 Fix UT errors due to ActiveMQ upgrade


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message