flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mschma...@apache.org
Subject svn commit: r1453329 - in /flex/falcon/trunk/compiler/src/org/apache/flex/compiler: internal/tree/as/FunctionCallNode.java internal/tree/as/ModifierNode.java tree/as/IFunctionCallNode.java
Date Wed, 06 Mar 2013 13:36:30 GMT
Author: mschmalle
Date: Wed Mar  6 13:36:30 2013
New Revision: 1453329

URL: http://svn.apache.org/r1453329
Log:
Flex:Falcon
- Added existing public API to IFunctionCallNode API

Modified:
    flex/falcon/trunk/compiler/src/org/apache/flex/compiler/internal/tree/as/FunctionCallNode.java
    flex/falcon/trunk/compiler/src/org/apache/flex/compiler/internal/tree/as/ModifierNode.java
    flex/falcon/trunk/compiler/src/org/apache/flex/compiler/tree/as/IFunctionCallNode.java

Modified: flex/falcon/trunk/compiler/src/org/apache/flex/compiler/internal/tree/as/FunctionCallNode.java
URL: http://svn.apache.org/viewvc/flex/falcon/trunk/compiler/src/org/apache/flex/compiler/internal/tree/as/FunctionCallNode.java?rev=1453329&r1=1453328&r2=1453329&view=diff
==============================================================================
--- flex/falcon/trunk/compiler/src/org/apache/flex/compiler/internal/tree/as/FunctionCallNode.java
(original)
+++ flex/falcon/trunk/compiler/src/org/apache/flex/compiler/internal/tree/as/FunctionCallNode.java
Wed Mar  6 13:36:30 2013
@@ -284,39 +284,25 @@ public class FunctionCallNode extends Ex
         return retVal.toArray(new IExpressionNode[0]);
     }
 
-    //
-    // Other methods
-    //
-    
-    // TODO Add to interface?
+    @Override
     public boolean isSuperExpression()
     {
         return nameNode instanceof ILanguageIdentifierNode && ((ILanguageIdentifierNode)nameNode).getKind()
== LanguageIdentifierKind.SUPER;
     }
 
-    /**
-     * Get the arguments being passed
-     * 
-     * @return node containing the arguments being passed to the function
-     */
-    // TODO Add to interface?
+    @Override
     public ContainerNode getArgumentsNode()
     {
         return argumentsNode;
     }
 
-    /**
-     * Get the new keyword, if one is present
-     * 
-     * @return node containing the new keyword
-     */
-    // TODO Add to interface?
+    @Override
     public KeywordNode getNewKeywordNode()
     {
         return newKeywordNode;
     }
 
-    // TODO Add to interface?
+    @Override
     public boolean isCallToSuper()
     {
         return nameNode instanceof ILanguageIdentifierNode &&

Modified: flex/falcon/trunk/compiler/src/org/apache/flex/compiler/internal/tree/as/ModifierNode.java
URL: http://svn.apache.org/viewvc/flex/falcon/trunk/compiler/src/org/apache/flex/compiler/internal/tree/as/ModifierNode.java?rev=1453329&r1=1453328&r2=1453329&view=diff
==============================================================================
--- flex/falcon/trunk/compiler/src/org/apache/flex/compiler/internal/tree/as/ModifierNode.java
(original)
+++ flex/falcon/trunk/compiler/src/org/apache/flex/compiler/internal/tree/as/ModifierNode.java
Wed Mar  6 13:36:30 2013
@@ -106,13 +106,13 @@ public class ModifierNode extends FixedC
     // IModifierNode implementations
     //
 
-    // TODO Add to interface.
+    @Override
     public ASModifier getModifier()
     {
         return modifier;
     }
 
-    // TODO Add to interface.
+    @Override
     public String getModifierString()
     {
         return modifier != null ? modifier.toString() : "";

Modified: flex/falcon/trunk/compiler/src/org/apache/flex/compiler/tree/as/IFunctionCallNode.java
URL: http://svn.apache.org/viewvc/flex/falcon/trunk/compiler/src/org/apache/flex/compiler/tree/as/IFunctionCallNode.java?rev=1453329&r1=1453328&r2=1453329&view=diff
==============================================================================
--- flex/falcon/trunk/compiler/src/org/apache/flex/compiler/tree/as/IFunctionCallNode.java
(original)
+++ flex/falcon/trunk/compiler/src/org/apache/flex/compiler/tree/as/IFunctionCallNode.java
Wed Mar  6 13:36:30 2013
@@ -20,6 +20,8 @@
 package org.apache.flex.compiler.tree.as;
 
 import org.apache.flex.compiler.definitions.IDefinition;
+import org.apache.flex.compiler.internal.tree.as.ContainerNode;
+import org.apache.flex.compiler.internal.tree.as.KeywordNode;
 import org.apache.flex.compiler.projects.ICompilerProject;
 
 /**
@@ -111,4 +113,34 @@ public interface IFunctionCallNode exten
      * @return true if this is a new expression
      */
     boolean isNewExpression();
+    
+    /**
+     * Returns true if this function call is part of a super expression
+     * <code> super(); </code>
+     * 
+     * @return true if this name node is a super expression
+     */
+    boolean isSuperExpression();
+    
+    /**
+     * Returns true if this function call is a call to a super expression
+     * <code>foo.super(); </code>
+     * 
+     * @return true if this name node calls a super expression
+     */
+    boolean isCallToSuper();
+    
+    /**
+     * Get the arguments being passed
+     * 
+     * @return node containing the arguments being passed to the function
+     */
+    ContainerNode getArgumentsNode();
+    
+    /**
+     * Get the new keyword, if one is present
+     * 
+     * @return node containing the new keyword
+     */
+    KeywordNode getNewKeywordNode();    
 }



Mime
View raw message