flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Harui <aha...@adobe.com>
Subject Re: [2/5] git commit: [flex-sdk] [refs/heads/develop] - FLEX-33731: solves 'access of possibly undefined property' that pops up when trying to compile 'experimental.swc' with Falcon. Not sure if this is a valid difference between the old compiler and F...
Date Mon, 23 Sep 2013 18:22:05 GMT


On 9/23/13 11:00 AM, "Erik de Bruin" <erik@ixsoftware.nl> wrote:

>I guess that's up to "Tink" to explain. All I know is that those 2
>lines after the we giving Falcon grief because that variable and
>method don't seem to be declared anywhere I could easily find and
>since the code won't execute in a meaningful way I figured commenting
>it out was the fastest route to making the Falcon tests pass...
OK, but there is a chance that MXMLC generated something useful and
commenting this code will leave it broken.

It looks like the numGraphicElements declaration in Group should be copied
into DeferredGroup.  The code in Group looks the same to me.  I'm guessing
Tink copied Group, made too many deletions and MXMLC didn't catch it.

-Alex

>
>EdB
>
>
>
>On Mon, Sep 23, 2013 at 6:51 PM, Alex Harui <aharui@adobe.com> wrote:
>> Hmm, not so sure about this one.  Why is this code not necessary?
>>
>> On 9/23/13 7:31 AM, "erikdebruin@apache.org" <erikdebruin@apache.org>
>> wrote:
>>
>>>FLEX-33731: solves 'access of possibly undefined property' that pops up
>>>when trying to compile 'experimental.swc' with Falcon. Not sure if this
>>>is a valid difference between the old compiler and Falcon, or if I'm
>>>just
>>>working around an issue that needs fixin'
>>>
>>>Signed-off-by: Erik de Bruin <erik@ixsoftware.nl>
>>>
>>>
>>>Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
>>>Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/638cc670
>>>Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/638cc670
>>>Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/638cc670
>>>
>>>Branch: refs/heads/develop
>>>Commit: 638cc670bd9505798dd7fbe7add7593198ec0220
>>>Parents: b53c294
>>>Author: Erik de Bruin <erik@ixsoftware.nl>
>>>Authored: Mon Sep 23 15:30:43 2013 +0200
>>>Committer: Erik de Bruin <erik@ixsoftware.nl>
>>>Committed: Mon Sep 23 15:30:43 2013 +0200
>>>
>>>----------------------------------------------------------------------
>>> .../projects/experimental/src/spark/containers/DeferredGroup.as  | 4
>>>++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>----------------------------------------------------------------------
>>>
>>>
>>>http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/638cc670/frameworks
>>>/p
>>>rojects/experimental/src/spark/containers/DeferredGroup.as
>>>----------------------------------------------------------------------
>>>diff --git
>>>a/frameworks/projects/experimental/src/spark/containers/DeferredGroup.as
>>>b/frameworks/projects/experimental/src/spark/containers/DeferredGroup.as
>>>index 94658b6..1bb6553 100644
>>>---
>>>a/frameworks/projects/experimental/src/spark/containers/DeferredGroup.as
>>>+++
>>>b/frameworks/projects/experimental/src/spark/containers/DeferredGroup.as
>>>@@ -955,8 +955,8 @@ package spark.containers
>>>                               // see
>>>https://bugs.adobe.com/jira/browse/SDK-25601
>>>                               //
>>>https://bugs.adobe.com/jira/browse/SDK-25333
>>>                               throw new Error( "You cannot use an
>>>IGraphicElement in a
>>>DeferredGroup, all elements must extend UIComponent" );
>>>-                              numGraphicElements++;
>>>-                              addingGraphicElementChild(element as
>>>IGraphicElement);
>>>+                              //numGraphicElements++;
>>>+                              //addingGraphicElementChild(element as
>>>IGraphicElement);
>>>                               invalidateDisplayObjectOrdering();
>>>                       }
>>>                       else
>>>
>>
>
>
>
>-- 
>Ix Multimedia Software
>
>Jan Luykenstraat 27
>3521 VB Utrecht
>
>T. 06-51952295
>I. www.ixsoftware.nl


Mime
View raw message