flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mkess...@apache.org
Subject git commit: [flex-sdk] [refs/heads/develop] - FLEX-33920: It now checks the upper bounds before calling dataProvider.getItemAt()
Date Thu, 21 Nov 2013 00:38:49 GMT
Updated Branches:
  refs/heads/develop 323882d8a -> c1b8214bc


FLEX-33920: It now checks the upper bounds before calling dataProvider.getItemAt()


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/c1b8214b
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/c1b8214b
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/c1b8214b

Branch: refs/heads/develop
Commit: c1b8214bcdfad6f20af43dd1a8d1a6b2345a1dd1
Parents: 323882d
Author: Mark Kessler <KesslerConsulting@gmail.com>
Authored: Wed Nov 20 19:37:37 2013 -0500
Committer: Mark Kessler <KesslerConsulting@gmail.com>
Committed: Wed Nov 20 19:37:37 2013 -0500

----------------------------------------------------------------------
 frameworks/projects/spark/src/spark/components/ComboBox.as | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/c1b8214b/frameworks/projects/spark/src/spark/components/ComboBox.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/spark/src/spark/components/ComboBox.as b/frameworks/projects/spark/src/spark/components/ComboBox.as
index e2ae977..2b67302 100644
--- a/frameworks/projects/spark/src/spark/components/ComboBox.as
+++ b/frameworks/projects/spark/src/spark/components/ComboBox.as
@@ -883,7 +883,7 @@ public class ComboBox extends DropDownListBase implements IIMESupport
     {
         super.changeHighlightedSelection(newIndex, scrollToTop);
         
-        if (newIndex >= 0)
+        if (newIndex >= 0 && newIndex < dataProvider.length)
         {
             var item:Object = dataProvider ? dataProvider.getItemAt(newIndex) : undefined;
             if (item && textInput)


Mime
View raw message