flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ha...@apache.org
Subject git commit: [flex-tlf] [refs/heads/develop] - Fixed an issue where some Operations were failing. I do not remember why I added normalizeRange() to this function, but I don't see any obvious issues with removing it.
Date Tue, 02 Dec 2014 10:24:06 GMT
Repository: flex-tlf
Updated Branches:
  refs/heads/develop 1e0722fa2 -> 0df892afb


Fixed an issue where some Operations were failing.
I do not remember why I added normalizeRange() to this function, but I don't see any obvious
issues with removing it.


Project: http://git-wip-us.apache.org/repos/asf/flex-tlf/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-tlf/commit/0df892af
Tree: http://git-wip-us.apache.org/repos/asf/flex-tlf/tree/0df892af
Diff: http://git-wip-us.apache.org/repos/asf/flex-tlf/diff/0df892af

Branch: refs/heads/develop
Commit: 0df892afba4a1e5206a8d7c41e90d1a30d2318e5
Parents: 1e0722f
Author: Harbs <harbs@in-tools.com>
Authored: Tue Dec 2 12:23:42 2014 +0200
Committer: Harbs <harbs@in-tools.com>
Committed: Tue Dec 2 12:23:42 2014 +0200

----------------------------------------------------------------------
 textLayout/src/flashx/textLayout/elements/FlowGroupElement.as | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-tlf/blob/0df892af/textLayout/src/flashx/textLayout/elements/FlowGroupElement.as
----------------------------------------------------------------------
diff --git a/textLayout/src/flashx/textLayout/elements/FlowGroupElement.as b/textLayout/src/flashx/textLayout/elements/FlowGroupElement.as
index 62567dd..a6ea842 100644
--- a/textLayout/src/flashx/textLayout/elements/FlowGroupElement.as
+++ b/textLayout/src/flashx/textLayout/elements/FlowGroupElement.as
@@ -991,7 +991,8 @@ package flashx.textLayout.elements
 				parent.replaceChildren(myidx+1,myidx+1,newSibling);
 			}
 
-			newSibling.normalizeRange(0,newSibling.textLength);
+			// This causes errors in operations that assume zero children. Normalizing makes this
assumption not valid.
+			//newSibling.normalizeRange(0,newSibling.textLength);
 			return newSibling;
 		}
 


Mime
View raw message