flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Harui <aha...@adobe.com>
Subject Re: git commit: [flex-sdk] [refs/heads/release4.14.0] - Changed FlatSpark property to maintain proportions' name to 'fixedAspectRatio'
Date Fri, 19 Dec 2014 16:48:02 GMT
You don’t have to make this change, but I just wanted to point out that
SWFLoader has a property called ‘maintainAspectRatio’.  Is this roughly
the same thing?

-Alex

On 12/19/14, 2:04 AM, "akamud@apache.org" <akamud@apache.org> wrote:

>Repository: flex-sdk
>Updated Branches:
>  refs/heads/release4.14.0 307b0d86d -> 58c17bc05
>
>
>Changed FlatSpark property to maintain proportions' name to
>'fixedAspectRatio'
>
>
>Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
>Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/58c17bc0
>Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/58c17bc0
>Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/58c17bc0
>
>Branch: refs/heads/release4.14.0
>Commit: 58c17bc052db9920a6451e343b038e685bc2d388
>Parents: 307b0d8
>Author: Mahmoud Ali <akamud@apache.org>
>Authored: Fri Dec 19 07:03:34 2014 -0300
>Committer: Mahmoud Ali <akamud@apache.org>
>Committed: Fri Dec 19 07:03:50 2014 -0300
>
>----------------------------------------------------------------------
> .../projects/flatspark/src/flatspark/components/ButtonIcon.as    | 2 +-
> .../projects/flatspark/src/flatspark/skins/ButtonIconSkin.mxml   | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>----------------------------------------------------------------------
>
>
>http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/58c17bc0/frameworks/p
>rojects/flatspark/src/flatspark/components/ButtonIcon.as
>----------------------------------------------------------------------
>diff --git 
>a/frameworks/projects/flatspark/src/flatspark/components/ButtonIcon.as
>b/frameworks/projects/flatspark/src/flatspark/components/ButtonIcon.as
>index e3f5620..14db46d 100644
>--- a/frameworks/projects/flatspark/src/flatspark/components/ButtonIcon.as
>+++ b/frameworks/projects/flatspark/src/flatspark/components/ButtonIcon.as
>@@ -32,7 +32,7 @@ package flatspark.components
> 		public var brand:int = BrandColorEnum.Default;
> 		
> 		[Bindable]
>-		public var fixedHeight:Boolean = true;
>+		public var fixedAspectRatio:Boolean = true;
> 
> 
> 		public function ButtonIcon()
>
>http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/58c17bc0/frameworks/p
>rojects/flatspark/src/flatspark/skins/ButtonIconSkin.mxml
>----------------------------------------------------------------------
>diff --git 
>a/frameworks/projects/flatspark/src/flatspark/skins/ButtonIconSkin.mxml
>b/frameworks/projects/flatspark/src/flatspark/skins/ButtonIconSkin.mxml
>index c7f03fc..995cb71 100644
>--- 
>a/frameworks/projects/flatspark/src/flatspark/skins/ButtonIconSkin.mxml
>+++ 
>b/frameworks/projects/flatspark/src/flatspark/skins/ButtonIconSkin.mxml
>@@ -90,7 +90,7 @@ limitations under the License.
> 			{
> 				var fontHeight:int = 14;
> 				
>-				if (hostComponent.fixedHeight)
>+				if (hostComponent.fixedAspectRatio)
> 				{
> 					switch (hostComponent.height)
> 					{
>@@ -123,7 +123,7 @@ limitations under the License.
> 			{
> 				var iconHeight:int = 17;				
> 				
>-				if (hostComponent.fixedHeight)
>+				if (hostComponent.fixedAspectRatio)
> 				{
> 					switch (hostComponent.height)
> 					{
>

Mime
View raw message