flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adufi...@apache.org
Subject git commit: [flex-falcon] [refs/heads/develop] - Revert "Array class should be dynamic" because we don't seem to gain anything by it. The Array class being dynamic in ActionScript may have been a workaround for a limitation caused by an implementation de
Date Mon, 18 Jan 2016 17:12:13 GMT
Repository: flex-falcon
Updated Branches:
  refs/heads/develop d346bed98 -> 6bd08f108


Revert "Array class should be dynamic" because we don't seem to gain anything by it.
The Array class being dynamic in ActionScript may have been a workaround for a limitation
caused by an implementation detail.

This reverts commit b74b09dd2c074ab6916dd11aa7526d4c857329cd.


Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/6bd08f10
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/6bd08f10
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/6bd08f10

Branch: refs/heads/develop
Commit: 6bd08f108b31814132c52ac2e12a03819d4bcb33
Parents: d346bed
Author: Andy Dufilie <andrew.dufilie@iweave.com>
Authored: Mon Jan 18 12:08:50 2016 -0500
Committer: Andy Dufilie <andrew.dufilie@iweave.com>
Committed: Mon Jan 18 12:11:54 2016 -0500

----------------------------------------------------------------------
 .../flex/compiler/internal/codegen/externals/TestExternES3.java    | 1 -
 .../internal/codegen/externals/reference/ReferenceModel.java       | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/6bd08f10/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/externals/TestExternES3.java
----------------------------------------------------------------------
diff --git a/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/externals/TestExternES3.java
b/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/externals/TestExternES3.java
index 24206d9..29ac6fb 100644
--- a/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/externals/TestExternES3.java
+++ b/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/externals/TestExternES3.java
@@ -86,7 +86,6 @@ public class TestExternES3 extends ExternalsTestBase
 
         ClassReference Array = model.getClassReference("Array");
         assertNotNull(Array);
-        assertTrue(Array.isDynamic());
 
         MethodReference constructor = Array.getConstructor();
         StringBuilder sb = new StringBuilder();

http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/6bd08f10/compiler.jx/src/org/apache/flex/compiler/internal/codegen/externals/reference/ReferenceModel.java
----------------------------------------------------------------------
diff --git a/compiler.jx/src/org/apache/flex/compiler/internal/codegen/externals/reference/ReferenceModel.java
b/compiler.jx/src/org/apache/flex/compiler/internal/codegen/externals/reference/ReferenceModel.java
index 62ae14f..090eb63 100644
--- a/compiler.jx/src/org/apache/flex/compiler/internal/codegen/externals/reference/ReferenceModel.java
+++ b/compiler.jx/src/org/apache/flex/compiler/internal/codegen/externals/reference/ReferenceModel.java
@@ -141,7 +141,7 @@ public class ReferenceModel
         ClassReference reference = new ClassReference(this, node, qualifiedName);
 
         // TODO (mschmalle) Figure out if gcc makes any decisions about what is final or
dynamic
-        if (reference.getQualifiedName().equals("Object") || reference.getQualifiedName().equals("Array"))
+        if (reference.getQualifiedName().equals("Object"))
             reference.setDynamic(true);
 
         classes.put(qualifiedName, reference);


Mime
View raw message