flex-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benoit Wiart (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLEX-33865) ConstraintLayout / LayoutElementHelper are memory inefficient (and slow)
Date Mon, 04 Nov 2013 00:04:17 GMT

    [ https://issues.apache.org/jira/browse/FLEX-33865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13812528#comment-13812528
] 

Benoit Wiart commented on FLEX-33865:
-------------------------------------

[~mamsellem]
>1) your test to trim spaces should use isWhiteSpace intead of == " "
Done

>2) Test with Number is actually slower than the original because of the manual Array construction
and the as operator
>when result is null, it's faster to return [ X , Y ] ; 
it's marginally faster and it will need more memory allocation

>Also, keep in mind that local optimization on functions that are already very fast, and
that are not called very often,
>may only have a small impact on the OVERALL application performance.
all the bugs i've created on the flex jira are driven by real world performance pb on mobile
(mainly ios)

>Although you cannot share your mobile app, do you have any idea, even subjective, on the
actual performance gain when >applying this optimization to the mobile app?
the screenshots (layout-2-desktop-memory.png, layout-1-desktop-memory.png) are from a real
world application on desktop.
file layout-3-mobile-memory.png is from the mobile version. I won't be able to give you the
'after' version BUT it will have similar memory allocation gain

[~jmclean]
in Contraintlayout the main user of parseConstraintExp is parseElementConstraints which needs
both elements.
I'm not sure if it will be faster : to be tested in a future improvement.


> ConstraintLayout / LayoutElementHelper are memory inefficient (and slow)
> ------------------------------------------------------------------------
>
>                 Key: FLEX-33865
>                 URL: https://issues.apache.org/jira/browse/FLEX-33865
>             Project: Apache Flex
>          Issue Type: Improvement
>          Components: Mobile: Performance, Spark: Layout
>    Affects Versions: Apache Flex 4.11.0
>         Environment: mobile desktop
>            Reporter: Benoit Wiart
>            Assignee: Maurice Amsellem
>              Labels: mobile, performance
>         Attachments: 0001-ConstraintLayout-optimizationsV2.patch, layout-1-desktop-memory.png,
layout-2-desktop-memory.png
>
>
> ConstraintLayout / LayoutElementHelper are doing too many memory allocation.
> it's really bad on mobile
> the attached screenshots were taken on desktop



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message