flex-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Justin Mclean (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLEX-33865) ConstraintLayout / LayoutElementHelper are memory inefficient (and slow)
Date Mon, 04 Nov 2013 02:09:17 GMT

    [ https://issues.apache.org/jira/browse/FLEX-33865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13812571#comment-13812571
] 

Justin Mclean commented on FLEX-33865:
--------------------------------------

Using this simple program:

<?xml version="1.0" encoding="utf-8"?>
<s:Application xmlns:fx="http://ns.adobe.com/mxml/2009" 
			   xmlns:s="library://ns.adobe.com/flex/spark" 
			   xmlns:mx="library://ns.adobe.com/flex/mx">
	
	<s:Form width="100%" height="100%">
		<s:FormItem label="First Name">
			<s:TextInput width="120" />
		</s:FormItem>
		<s:FormItem label="Last Name">
			<s:TextInput width="120"/>
		</s:FormItem>
		<s:FormItem label="Gender">
			<s:layout>
				<s:HorizontalLayout />
			</s:layout>
			<s:RadioButton label="M" />
			<s:RadioButton label="F" />
		</s:FormItem>
		<s:FormItem label="Info">
			<s:TextArea width="100%" height="100%" />
		</s:FormItem>
	</s:Form>
</s:Application>

Run and tested on Desktop with scout both with and without patch. Waited five seconds then
resized the browser window continually for 10 seconds. Not really a real world example but
the simplest way I could think of of testing. (DOCreateTextLine takes same time so comparison
should be fair.)

Patch overall time (mostly because string methods _replace and _split are not called) by 30%.
 Total time in parseConstraintExp when from 240 ms to undetectable. 

Garbage collection 7% of total to 3% of total. Performance impact is likely to be greater
on mobile.




> ConstraintLayout / LayoutElementHelper are memory inefficient (and slow)
> ------------------------------------------------------------------------
>
>                 Key: FLEX-33865
>                 URL: https://issues.apache.org/jira/browse/FLEX-33865
>             Project: Apache Flex
>          Issue Type: Improvement
>          Components: Mobile: Performance, Spark: Layout
>    Affects Versions: Apache Flex 4.11.0
>         Environment: mobile desktop
>            Reporter: Benoit Wiart
>            Assignee: Maurice Amsellem
>              Labels: mobile, performance
>         Attachments: 0001-ConstraintLayout-optimizationsV2.patch, layout-1-desktop-memory.png,
layout-2-desktop-memory.png, layout-3-mobile-memory.png
>
>
> ConstraintLayout / LayoutElementHelper are doing too many memory allocation.
> it's really bad on mobile
> the attached screenshots were taken on desktop



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message