flex-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Morten Gorm Madsen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLEX-34117) Button: Small gap in the corner
Date Mon, 03 Mar 2014 09:03:21 GMT

    [ https://issues.apache.org/jira/browse/FLEX-34117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13917851#comment-13917851
] 

Morten Gorm Madsen commented on FLEX-34117:
-------------------------------------------

I'd rather show you the options since I don't know the design plans =) 

Option 1: Alter layoutCornerEllipseSize to fit up/down-skins
spark.skin.mobile.ButtonSkin,
DPIClassification.DPI_640
DPIClassification.DPI_480
DPIClassification.DPI_320
layoutCornerEllipseSize = 15;

Option 2: Alter the fxps to fit layoutCornerEllipseSize
spark.skins.mobile640.assets.Button_down
spark.skins.mobile640.assets.Button_up
spark.skins.mobile480.assets.Button_down
spark.skins.mobile480.assets.Button_up
spark.skins.mobile320.assets.Button_down
spark.skins.mobile320.assets.Button_up
I dont want to do that by hand - sorry.

Option 3:
Why use a mix of fxp and programmatic skins?
Isn't it easier in a multi dpi scheme to use only graphics.drawRoundRect() OR fxp skins?
I'd prefer skins set to null, css used to define cornerRadius, padding, gap etc.
But I guess that's another discussion =)

Option 1 is easier
Option 2 is "correct"
Option 3 is preferred

> Button: Small gap in the corner
> -------------------------------
>
>                 Key: FLEX-34117
>                 URL: https://issues.apache.org/jira/browse/FLEX-34117
>             Project: Apache Flex
>          Issue Type: Bug
>          Components: Mobile: Button Skin
>    Affects Versions: Apache Flex 4.11.0
>         Environment: Mobile, DPI320, DPI480, DPI640
>            Reporter: Morten Gorm Madsen
>            Priority: Trivial
>         Attachments: gap.png
>
>
> Button has a small gap in the corners on DPI320, DPI480 and DPI640.
> The gap on DPI320 is barely visible.
> The gap on DPI480 is visible on Samsung S4 when you know it is there.
> The gap on DPI640 is visible on theoretical future XXXHDPI devices.
> Seems like the cornerRadius of the stroke is not the same as the fill(s).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message