flex-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLEX-34769) TLF Performance issue (applyLeafFormat method)
Date Wed, 09 Dec 2015 12:02:10 GMT

    [ https://issues.apache.org/jira/browse/FLEX-34769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048565#comment-15048565

Harbs commented on FLEX-34769:

It seems to boil down to FlowComposerBase.addLiine(). There's some odd code in there with
no comments to explain why it's necessary.
// Making a new line in the middle of an old one. Need to split the old one.


// We're composing ahead, so we need to split the line where we're at
// This can happen if a table is getting composed, some cells can be composed before 
// others that go before. 

The first one I understand a little bit. I imagine you have a composed line and then the contents
get pushed to the next line, you need to adjust the previous one. But I don't understand why
it's adding an extra line after the one being inserted. That's causing problems for me, and
I don't understand why it's necessary.

The second one I do not understand at all. I was assuming that it was for the uncompleted
table code which I totally rewrote to make composition of tables easier to grasp. However,
this code was in Flex 4.6 which I don't think had support for tables at all.

If anyone has any pointers here, I'd really appreciate it...

> TLF Performance issue (applyLeafFormat method)
> ----------------------------------------------
>                 Key: FLEX-34769
>                 URL: https://issues.apache.org/jira/browse/FLEX-34769
>             Project: Apache Flex
>          Issue Type: Bug
>          Components: TLF
>    Affects Versions: Apache Flex 4.10.0, Apache Flex 4.11.0, Apache Flex 4.12.0, Apache
Flex 4.13.0, Apache Flex 4.14.0
>         Environment: OS: Windows 7
> AIR version: 15 and 16
> CPU: Intel i7 2630h 
> RAM: 4GB
>            Reporter: goratz
>            Assignee: Harbs
>              Labels: flex, performance, tlf
>             Fix For: Apache Flex 4.9.0
>         Attachments: TLFPerfTest.as, TLF_Bench.fla, textLayout_14.swc, textLayout_9.1.swc
> I have a very strange performance difference between 2 versions of TextLayout.swc. The
first one is the swc included in Apache Flex 4.14 SDK and the second one is included in Apache
Flex 4.9.1. 
> I have a very large text, more or less 200 DIN-A4 pages in a Textflow. I scroll to the
end of the document and I underline a word. This is my result underling a word in both versions.

> Flex SDK Version     Time 
>    4.9.1                  21 ms (miliseconds). 0,02 Seconds 
>    4.14                   3.405 ms (miliseconds). 3,4 Seconds 
> The time difference happens in this line of code: 
> EditManager.applyLeafFormat(oFormat); 
> Anyone has any idea what's the problem? 
> More info: https://issues.apache.org/jira/browse/FLEX/?selectedTab=com.atlassian.jira.jira-projects-plugin:issues-panel

This message was sent by Atlassian JIRA

View raw message