flex-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andy Dufilie (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLEX-34983) Variables get annotated incorrectly when the class name contains "String"
Date Fri, 11 Dec 2015 09:42:11 GMT

    [ https://issues.apache.org/jira/browse/FLEX-34983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052527#comment-15052527

Andy Dufilie commented on FLEX-34983:

mapBackToJS was just a guess.  I'm not familiar with the code base, but it was the only place
I was able to find which did the type of string replacement I observed.

Both flexjs/js/bin/compc and flexjs/js/bin/mxmlc produce the same result.

> Variables get annotated incorrectly when the class name contains "String"
> -------------------------------------------------------------------------
>                 Key: FLEX-34983
>                 URL: https://issues.apache.org/jira/browse/FLEX-34983
>             Project: Apache Flex
>          Issue Type: Bug
>          Components: Falcon, FlexJS
>    Affects Versions: Apache FlexJS 0.5.0
>            Reporter: Andy Dufilie
>            Assignee: Alex Harui
>            Priority: Minor
> If you create a class with "String" in the name, the type gets annotated incorrectly.
> For example, create a class named "LinkableString" and it becomes "Linkablestring" in
the annotation, causing warnings as follows:
> {code}
> WARNING: C:\Weave\WeaveJS\bin\js-debug\WeaveTest.js:74: WARNING - Bad type annotation.
Unknown type weavejs.core.Linkablestring
>   var /** @type {weavejs.core.Linkablestring} */ test = new weavejs.core.LinkableString();
> {code}
> I believe the offending code is in mapBackToJS() in BaseReference.java:
> https://github.com/apache/flex-falcon/blob/808fd1601a0228883b06d061d0f6bd101888284e/compiler.jx/src/org/apache/flex/compiler/internal/codegen/externals/reference/BaseReference.java#L201

This message was sent by Atlassian JIRA

View raw message