flex-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Harui (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLEX-35006) bug in mxmlc/compc/etc scripts when flexjs path contains spaces
Date Thu, 24 Dec 2015 15:22:49 GMT

    [ https://issues.apache.org/jira/browse/FLEX-35006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15071086#comment-15071086
] 

Alex Harui commented on FLEX-35006:
-----------------------------------

That would be great!  Pull Requests are a fine way to deliver patches.

For compiler bugs, you may have noticed that I am trying to create unit tests for each of
your issues.  Even if you don't know how to fix the compiler, if you have time to create unit
tests as a patch or pull request that would be better than having a small failure case, although
it is fine just to have those small test cases and you do a great job of creating those.

Thanks,
Alex

> bug in mxmlc/compc/etc scripts when flexjs path contains spaces
> ---------------------------------------------------------------
>
>                 Key: FLEX-35006
>                 URL: https://issues.apache.org/jira/browse/FLEX-35006
>             Project: Apache Flex
>          Issue Type: Bug
>          Components: Falcon, FlexJS
>    Affects Versions: Apache FlexJS 0.5.0
>            Reporter: Andy Dufilie
>
> Any place {{`dirname $0`}} appears in a shell script, it should be changed to {{`dirname
"$0"`}} so that it works with paths containing spaces.
> A quick search shows which files are affected:
> {code}
> bin/compc (2 matches)
> 	29: SCRIPT_HOME=`dirname $0` 
> 	37: SCRIPT_HOME=`dirname $0` 
> bin/mxmlc (2 matches)
> 	29: SCRIPT_HOME=`dirname $0` 
> 	37: SCRIPT_HOME=`dirname $0` 
> bin/optimizer
> 	29: SCRIPT_HOME=`dirname $0` 
> bin/swcdepends (2 matches)
> 	29: SCRIPT_HOME=`dirname $0` 
> 	37: SCRIPT_HOME=`dirname $0` 
> bin/swfdump
> 	29: SCRIPT_HOME=`dirname $0` 
> flex-asjs/js/bin/asjsc
> 	28: SCRIPT_HOME=`dirname $0` 
> flex-asjs/js/bin/asjscompc
> 	30: SCRIPT_HOME=`dirname $0` 
> flex-asjs/js/bin/compc
> 	30: SCRIPT_HOME=`dirname $0` 
> flex-asjs/js/bin/externc
> 	28: SCRIPT_HOME=`dirname $0` 
> flex-asjs/js/bin/jquery
> 	28: SCRIPT_HOME=`dirname $0` 
> flex-asjs/js/bin/mxmlc
> 	28: SCRIPT_HOME=`dirname $0` 
> flex-asjs/scripts/deploy.sh
> 	64: RELBASEDIR=$(dirname $0) 
> flex-asjs/scripts/setuplaunches.sh
> 	49: BASEDIR=$(dirname $0) 
> js/bin/asjsc
> 	28: SCRIPT_HOME=`dirname $0` 
> js/bin/asjscompc
> 	30: SCRIPT_HOME=`dirname $0` 
> js/bin/compc
> 	30: SCRIPT_HOME=`dirname $0` 
> js/bin/externc
> 	28: SCRIPT_HOME=`dirname $0` 
> js/bin/jquery
> 	28: SCRIPT_HOME=`dirname $0` 
> js/bin/mxmlc
> 	28: SCRIPT_HOME=`dirname $0` 
> scripts/deploy.sh
> 	64: RELBASEDIR=$(dirname $0) 
> scripts/setuplaunches.sh
> 	49: BASEDIR=$(dirname $0) 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message