[ https://issues.apache.org/jira/browse/FLEX-35006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15071236#comment-15071236 ] 

ASF GitHub Bot commented on FLEX-35006:
---------------------------------------

GitHub user adufilie opened a pull request:

    https://github.com/apache/flex-falcon/pull/1

    Changed `dirname $0` to `dirname "$0"` to support paths with spaces

    See https://issues.apache.org/jira/browse/FLEX-35006

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/adufilie/flex-falcon develop

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flex-falcon/pull/1.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1
    
----
commit 3f7bcc02e81a2627c1fa23c47b655f9a1a306de7
Author: Andy Dufilie <andrew.dufilie@iweave.com>
Date:   2015-12-24T20:44:08Z

    Changed `dirname $0` to `dirname "$0"` to support paths containing spaces

----


> bug in mxmlc/compc/etc scripts when flexjs path contains spaces
> ---------------------------------------------------------------
>
>                 Key: FLEX-35006
>                 URL: https://issues.apache.org/jira/browse/FLEX-35006
>             Project: Apache Flex
>          Issue Type: Bug
>          Components: Falcon, FlexJS
>    Affects Versions: Apache FlexJS 0.5.0
>            Reporter: Andy Dufilie
>
> Any place {{`dirname $0`}} appears in a shell script, it should be changed to {{`dirname "$0"`}} so that it works with paths containing spaces.
> A quick search shows which files are affected:
> {code}
> bin/compc (2 matches)
> 	29: SCRIPT_HOME=`dirname $0` 
> 	37: SCRIPT_HOME=`dirname $0` 
> bin/mxmlc (2 matches)
> 	29: SCRIPT_HOME=`dirname $0` 
> 	37: SCRIPT_HOME=`dirname $0` 
> bin/optimizer
> 	29: SCRIPT_HOME=`dirname $0` 
> bin/swcdepends (2 matches)
> 	29: SCRIPT_HOME=`dirname $0` 
> 	37: SCRIPT_HOME=`dirname $0` 
> bin/swfdump
> 	29: SCRIPT_HOME=`dirname $0` 
> flex-asjs/js/bin/asjsc
> 	28: SCRIPT_HOME=`dirname $0` 
> flex-asjs/js/bin/asjscompc
> 	30: SCRIPT_HOME=`dirname $0` 
> flex-asjs/js/bin/compc
> 	30: SCRIPT_HOME=`dirname $0` 
> flex-asjs/js/bin/externc
> 	28: SCRIPT_HOME=`dirname $0` 
> flex-asjs/js/bin/jquery
> 	28: SCRIPT_HOME=`dirname $0` 
> flex-asjs/js/bin/mxmlc
> 	28: SCRIPT_HOME=`dirname $0` 
> flex-asjs/scripts/deploy.sh
> 	64: RELBASEDIR=$(dirname $0) 
> flex-asjs/scripts/setuplaunches.sh
> 	49: BASEDIR=$(dirname $0) 
> js/bin/asjsc
> 	28: SCRIPT_HOME=`dirname $0` 
> js/bin/asjscompc
> 	30: SCRIPT_HOME=`dirname $0` 
> js/bin/compc
> 	30: SCRIPT_HOME=`dirname $0` 
> js/bin/externc
> 	28: SCRIPT_HOME=`dirname $0` 
> js/bin/jquery
> 	28: SCRIPT_HOME=`dirname $0` 
> js/bin/mxmlc
> 	28: SCRIPT_HOME=`dirname $0` 
> scripts/deploy.sh
> 	64: RELBASEDIR=$(dirname $0) 
> scripts/setuplaunches.sh
> 	49: BASEDIR=$(dirname $0) 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)