flex-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "JC (JIRA)" <j...@apache.org>
Subject [jira] [Created] (FLEX-35293) Condition that always returns true
Date Tue, 18 Apr 2017 19:51:41 GMT
JC created FLEX-35293:

             Summary: Condition that always returns true
                 Key: FLEX-35293
                 URL: https://issues.apache.org/jira/browse/FLEX-35293
             Project: Apache Flex
          Issue Type: Bug
          Components: Falcon
            Reporter: JC
            Priority: Trivial


In a recent snapshot from GirHub mirror (flex-falcon), I've found a suspicious code in compiler/src/main/java/org/apache/flex/compiler/internal/config/localization/LocalizationManager.java

133     public String getLocalizedTextString( Locale locale, String id, Map<String, Object>
parameters )
134     {
135         ILocalizedText t = getLocalizedText( locale, id );
137         if ((t == null) && !locale.equals(locale))
138         {
139             t = getLocalizedText(locale, id );
140         }
In Line 137, locale.equals(locale) should be locale.equals(*this*.locale)? If there is a contract
that this.locale and locale is always same before calling getLocalizedTextString, this might
not be an issue. But wanted to report just in case. Thanks!

This message was sent by Atlassian JIRA

View raw message