flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-888) Add swap() method to Tuple2
Date Fri, 27 Jun 2014 11:46:26 GMT

    [ https://issues.apache.org/jira/browse/FLINK-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14045851#comment-14045851
] 

ASF GitHub Bot commented on FLINK-888:
--------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/44#discussion_r14288968
  
    --- Diff: stratosphere-java/src/main/java/eu/stratosphere/api/java/tuple/Tuple2.java ---
    @@ -99,6 +99,15 @@ public void setFields(T0 value0, T1 value1) {
     		this.f1 = value1;
     	}
     
    +	/**
    +	* Returns a shallow copy of the Tuple2 with swapped values.
    +	*
    +	* @return A Tuple2<T1, T0> shallow copy. Value0 and value1 are swapped.
    --- End diff --
    
    I think this comment is a bit ambiguous... I would say either remove the `@return` or
just copy the `Shallow copy of the Tuple2 with swapped values.`.


> Add swap() method to Tuple2
> ---------------------------
>
>                 Key: FLINK-888
>                 URL: https://issues.apache.org/jira/browse/FLINK-888
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: GitHub Import
>            Assignee: Tobias
>              Labels: github-import
>             Fix For: pre-apache
>
>
> In line with Scala
> ---------------- Imported from GitHub ----------------
> Url: https://github.com/stratosphere/stratosphere/issues/888
> Created by: [StephanEwen|https://github.com/StephanEwen]
> Labels: enhancement, java api, 
> Milestone: Release 0.6 (unplanned)
> Created at: Thu May 29 14:49:49 CEST 2014
> State: open



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message