flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-990) Scala API: Compiler Hints are not forwarded
Date Mon, 30 Jun 2014 10:10:24 GMT

    [ https://issues.apache.org/jira/browse/FLINK-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14047513#comment-14047513

ASF GitHub Bot commented on FLINK-990:

GitHub user tillrohrmann opened a pull request:


    FLINK-990 Scala API: Compiler Hints are not forwarded

    Added constant fields and combinable annotations forwarding to Scala API. The problem
is that annotations information is not available when the Operators are created. Thus, we
need a operator translation similar to the new Java API which triggers an update of the respective
semantic information.  Furthermore, the Scala generated annotations are appended to the operator
class, whereas the udf is checked for annotations. That's why Scala's combinableReduce operation
does not generate a combinable operator.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/incubator-flink FLINK-990

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #51
commit 735e93cd17df35b7f7340c777d03e57f00562472
Author: Till Rohrmann <till.rohrmann@gmail.com>
Date:   2014-06-30T09:45:49Z

    Added constant fields and combinable annotations forwarding to Scala API


> Scala API: Compiler Hints are not forwarded
> -------------------------------------------
>                 Key: FLINK-990
>                 URL: https://issues.apache.org/jira/browse/FLINK-990
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
> The Scala API contains functions such as preserve, observe, neglect, uniqueKey etc. which
can be used to specify compiler hints. However, they are not forwarded to the compiler. Thus
an operation:
> DataSet[A] ds = input.map{ x=> x}
> ds.preserve(x=>x, y=>y)
> which should say that the fields stay constant, does not have an effect. 

This message was sent by Atlassian JIRA

View raw message