flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: [FLINK-909], [FLINK945] Remove addit...
Date Fri, 08 Aug 2014 08:27:07 GMT
Github user uce commented on the pull request:

    https://github.com/apache/incubator-flink/pull/91#issuecomment-51575648
  
    Nice addition to get rid of the empty last iteration. Looks good to me :-) I've posted
minor comments inline. After @rmetzger tested it, I think it's good to merge.
    
    Could you reproduce the memory issue (FLINK-945) locally? If yes, can you explain what
was the exact problem? I am wondering, because in theory the last iteration should not cause
any problems, right?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message