flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1070) Change return type of "getBroadcastVariable()" from Collection to List
Date Fri, 29 Aug 2014 17:35:54 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14115539#comment-14115539

ASF GitHub Bot commented on FLINK-1070:

GitHub user StephanEwen opened a pull request:


    [FLINK-1070] Change return type of "getBroadcastVariable()" to List.

    `List` is much better to work with than `Collection`. The internal representation was
a list anyways.
    The change breaks the binary compatibility, but not source compatibility, since `List<T>`can
always be cast to `Collection<T>`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StephanEwen/incubator-flink bc_lists

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #105
commit 30ee70a96f663d5aee4ceccfbd601fce34ccf010
Author: Stephan Ewen <sewen@apache.org>
Date:   2014-08-29T17:32:40Z

    [FLINK-1070] Change return type of "getBroadcastVariable()" to List.


> Change return type of "getBroadcastVariable()" from Collection to List
> ----------------------------------------------------------------------
>                 Key: FLINK-1070
>                 URL: https://issues.apache.org/jira/browse/FLINK-1070
>             Project: Flink
>          Issue Type: Bug
>          Components: Java API
>    Affects Versions: 0.7-incubating
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>            Priority: Minor
>              Labels: api-breaking, simple
> The type is actually a List.
> Collections are a very reduces interface, it is much easier to work with Lists.

This message was sent by Atlassian JIRA

View raw message