flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1075) Race condition in AsynchronousPartialSorterITCase
Date Thu, 28 Aug 2014 16:36:08 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113935#comment-14113935
] 

ASF GitHub Bot commented on FLINK-1075:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/incubator-flink/pull/104

    [FLINK-1075] Removed the AsynchronousPartialSorter

    As proposed by @StephanEwen, I removed the AsynchronousPartialSorter within the GroupReduceCombinerDriver
and deleted the source files and the corresponding test cases.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/incubator-flink removeAsynchronousPartialSorter

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #104
    
----
commit 338dd63a2d6b98f4d3f750ea1ccf689ef001e351
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2014-08-28T16:28:20Z

    Removed the AsynchronousPartialSorter.

----


> Race condition in AsynchronousPartialSorterITCase
> -------------------------------------------------
>
>                 Key: FLINK-1075
>                 URL: https://issues.apache.org/jira/browse/FLINK-1075
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>
> I encountered a race condition in the AsynchronousPartialSorterITCase which causes the
test to fail non-deterministically. The sorter is legacy code and is only needed in the GroupReduceCombinerDriver.
[~StephanEwen] proposed to replace the code in the GroupReduceCombineDriver and to delete
the AsynchronousPartialSorter.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message