flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: [FLINK-1025] Integration of new BLOB...
Date Mon, 01 Sep 2014 10:38:18 GMT
Github user rmetzger commented on the pull request:

    https://github.com/apache/incubator-flink/pull/107#issuecomment-54045042
  
    Looks like a lot of work.
    
    Two comments:
    - The code seems to be incompatible with java 6: https://s3.amazonaws.com/archive.travis-ci.org/jobs/34053968/log.txt
    - I think the pull request contains a lot of commits (in particular duplicate messages
/ merge commits). Can you squash some of them to have only 1-5 commits in this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message