flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: Remove space after comma for TupleXX...
Date Tue, 16 Sep 2014 12:05:27 GMT
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/118#discussion_r17596758
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/tuple/Tuple10.java ---
    @@ -205,15 +205,15 @@ public void setFields(T0 value0, T1 value1, T2 value2, T3 value3,
T4 value4, T5
     	@Override
     	public String toString() {
     		return "(" + StringUtils.arrayAwareToString(this.f0)
    -			+ ", " + StringUtils.arrayAwareToString(this.f1)
    -			+ ", " + StringUtils.arrayAwareToString(this.f2)
    -			+ ", " + StringUtils.arrayAwareToString(this.f3)
    -			+ ", " + StringUtils.arrayAwareToString(this.f4)
    -			+ ", " + StringUtils.arrayAwareToString(this.f5)
    -			+ ", " + StringUtils.arrayAwareToString(this.f6)
    -			+ ", " + StringUtils.arrayAwareToString(this.f7)
    -			+ ", " + StringUtils.arrayAwareToString(this.f8)
    -			+ ", " + StringUtils.arrayAwareToString(this.f9)
    +			+ "," + StringUtils.arrayAwareToString(this.f1)
    --- End diff --
    
    I think if you concatenate a char (',') rather than a string, it is more efficient, but
that is a minor improvement.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message