flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: [FLINK-1062] Type Extraction for Lam...
Date Tue, 16 Sep 2014 12:11:41 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/113#discussion_r17596956
  
    --- Diff: flink-java8-tests/pom.xml ---
    @@ -130,6 +147,25 @@ under the License.
     										<ignore></ignore>
     									</action>
     								</pluginExecution>
    +								<pluginExecution>
    +									<pluginExecutionFilter>
    +										<groupId>
    +											org.apache.maven.plugins
    --- End diff --
    
    We usually don't define simple "key/value" style entries like this (in three lines).
    It is quite common for maven to have
    ```xml
    <groupId>org.apache.maven.plugins</groupId>
    ```
    and so on ..
    
    Its minor, but we should treat our pom files with a bit more love (they are quite messy
in some places)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message