flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: Change logging backend of SLF4j from...
Date Wed, 24 Sep 2014 08:11:56 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/125#discussion_r17958727
  
    --- Diff: flink-addons/flink-yarn/src/main/java/org/apache/flink/yarn/Client.java ---
    @@ -416,10 +422,16 @@ public boolean accept(File dir, String name) {
     
     		String amCommand = "$JAVA_HOME/bin/java"
     					+ " -Xmx"+Utils.calculateHeapSize(jmMemory)+"M " +javaOpts;
    +		if(hasLogback || hasLog4j) {
    +			amCommand += " -Dlog.file=\""+ApplicationConstants.LOG_DIR_EXPANSION_VAR +"/jobmanager-main.log\"
";
    +		}
     		if(hasLogback) {
    -			amCommand 	+= " -Dlog.file=\""+ApplicationConstants.LOG_DIR_EXPANSION_VAR +"/jobmanager-logback.log\"
" +
    -					"-Dlogback.configurationFile=file:logback.xml";
    +			amCommand += " -Dlogback.configurationFile=file:logback.xml";
     		}
    +		if(hasLog4j) {
    +			amCommand += " -Dlog4j.configuration=file:log4j.properties ";
    --- End diff --
    
    Thank you. I addressed both comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message