flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: Cleanup LOG.debug to make sure no ex...
Date Fri, 26 Sep 2014 08:41:25 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/127#discussion_r18079075
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/DefaultInputSplitAssigner.java
---
    @@ -63,11 +63,9 @@ public InputSplit getNextInputSplit(String host) {
     		
     		if (LOG.isDebugEnabled()) {
     			if (next == null) {
    -				LOG.debug("Assigning split " + next + " to " + host);
    +				LOG.debug("No more input splits available");
     			} else {
    -				if (LOG.isDebugEnabled()) {
    -					LOG.debug("No more input splits available");
    -				}
    +				LOG.debug("Assigning split " + next + " to " + host);
    --- End diff --
    
    Why not using parameterized logging?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message