flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-514) Fix invalid Javadoc references
Date Sun, 28 Sep 2014 09:07:34 GMT

    [ https://issues.apache.org/jira/browse/FLINK-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151052#comment-14151052
] 

ASF GitHub Bot commented on FLINK-514:
--------------------------------------

GitHub user warneke opened a pull request:

    https://github.com/apache/incubator-flink/pull/129

    [FLINK-514]  Fixed javadoc problems in various problems

    This pull requests fixes all javadoc warnings as reported by the maven build process except
for the warnings from the flink-streaming-core module. flink-streaming-core references interfaces
in the javadoc which do not exist anymore and it is not obvious to me how to change the javadoc.
    
    The code changes in the pull request only affect javadoc. No actual program code has been
touched.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/warneke/incubator-flink javadoc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/129.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #129
    
----
commit 1ccdd6b26ab71b92973f1b7307a21ea02155fe50
Author: Daniel Warneke <warneke@apache.org>
Date:   2014-07-21T06:01:09Z

    Worked on [FLINK-514]

commit 5188a5f70e68ee9625699301e58b46e2576bc65f
Author: Daniel Warneke <warneke@apache.org>
Date:   2014-07-21T18:49:58Z

    Fixed typo in contributors file

commit 2543a508ad8d586378e984f699b773bf6b588085
Author: Daniel Warneke <warneke@apache.org>
Date:   2014-07-21T18:50:54Z

    Merge branch 'master' into javadoc

commit 77fa0290d26f20708bc2391e78489c48fcebbb6a
Author: Daniel Warneke <warneke@apache.org>
Date:   2014-09-27T15:47:43Z

    Merge branch 'master' into javadoc
    
    Conflicts:
    	CONTRIBUTORS
    	flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/deployment/GateDeploymentDescriptor.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptor.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/event/job/ManagementEvent.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/event/task/AbstractEvent.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGate.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/JobStatusListener.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/instance/HardwareDescription.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/iomanager/ChannelReaderInputView.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/iomanager/ChannelWriterOutputView.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/iomanager/Deserializer.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/iomanager/HeaderlessChannelReaderInputView.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/iomanager/IOManager.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/io/network/ChannelManager.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/io/network/RemoteReceiver.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/MutableReader.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/ipc/Client.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/ipc/RPC.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/ipc/Server.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/iterative/concurrent/SolutionSetUpdateBarrier.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/iterative/concurrent/SolutionSetUpdateBarrierBroker.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/iterative/io/SolutionSetFastUpdateOutputCollector.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/iterative/io/SolutionSetUpdateOutputCollector.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/iterative/task/IterationHeadPactTask.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/iterative/task/IterationIntermediatePactTask.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/iterative/task/IterationSynchronizationSinkTask.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/iterative/task/IterationTailPactTask.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobEdge.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/tasks/InputSplitIterator.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/tasks/InputSplitProvider.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/EventCollector.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/archive/ArchiveListener.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/archive/MemoryArchivist.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/splitassigner/DefaultInputSplitAssigner.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/splitassigner/InputSplitManager.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/managementgraph/ManagementEdge.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/managementgraph/ManagementGroupEdge.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/managementgraph/ManagementGroupVertex.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/managementgraph/ManagementGroupVertexID.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/managementgraph/ManagementVertex.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/AbstractMutableHashTable.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/MergeIterator.java
    	flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/UnilateralSortMerger.java

commit 949b712328d6158251e0ee16da19b5ac3860897e
Author: Daniel Warneke <warneke@apache.org>
Date:   2014-09-28T08:52:16Z

    Fixed various javadoc problems

----


> Fix invalid Javadoc references
> ------------------------------
>
>                 Key: FLINK-514
>                 URL: https://issues.apache.org/jira/browse/FLINK-514
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: GitHub Import
>            Assignee: Daniel Warneke
>            Priority: Minor
>              Labels: github-import
>             Fix For: pre-apache
>
>
> When building the project, there are a lot of warnings, because of invalid Javadoc references.
One major source of this is imo that Eclipse does not complain with the default settings.
Let's make sure to keep it in mind for future doc comments and fix the bad ones (although
low priority for the system itself, I think it affects the perception of the code quality).
> ---------------- Imported from GitHub ----------------
> Url: https://github.com/stratosphere/stratosphere/issues/514
> Created by: [uce|https://github.com/uce]
> Labels: build system, enhancement, simple-issue, 
> Created at: Wed Feb 26 15:35:50 CET 2014
> State: open



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message